Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPvtg-0003Bm-V3 for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Sep 2021 00:02:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mPvtf-0000dR-TZ for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Sep 2021 00:01:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPvtf-0000d6-JM for pgsql-hackers@lists.postgresql.org; Tue, 14 Sep 2021 00:01:59 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPvtd-0008WH-FG for pgsql-hackers@lists.postgresql.org; Tue, 14 Sep 2021 00:01:58 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 1286D3200392; Mon, 13 Sep 2021 20:01:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 13 Sep 2021 20:01:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm2; bh=a z5GCAOx24jJn+k2YPBStsDVZQjNTeD0YYEgqoRr1hA=; b=jLl74uXvZ0LUnkmKE J1OdAN07DwoWkE1u+clc+E83meSXzsjTa1rmx+pNJRaCfVEst5rhm6sf9B9TFLvE l0aDcoo+FwaRbSTRKCR319e81W/TRfvm0eHDb+3falE9xQAx+TNexqwL4s58hk1k sJqKvj6n+IrzLlC71/DiDJI0DYlIV2sCQVELTusx7oXzML2hvK7hoeE7RN0/JffI +kicZSCFA07+VeOWONSD+uPoJcndetKlNU/C+nQY3p2fxXnvlfYj0Kf8KHnwL6Lr 7wBm1Z3SOULK3vMjBmDCxGRZfo/8mj8hIvO4ZDvynlNHik+fIJLJqZYsOf2fXPLk gg2tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=az5GCAOx24jJn+k2YPBStsDVZQjNTeD0YYEgqoRr1 hA=; b=m12/SiWCcIzpgnwtSxR2FZkfRT/pT0NRqlDYAntl2nU8l8InaIfh6M1cK cAzDim2fyNXo6VL2MnN5MBfxmXD2bKaRDI+3dyw4YTL4LOTZVdFFvwISNUnobqWF JyI/WRnXOpntk0gpE+sOgXgH5WkNaoKxJL9VOqgCW8rGLlVZdjr2viuRfpGTAeQK 27EKEHYYB7maSz4oPYdDlxvs95bVNtOoLy3yGueUx+VT6U7FhWmP8GM03IBslA9k uJMTPt7QASWhoZfOPHArHvpdvdNYJ73Dz/khzwKLvQmg5CgLiOA36wYDmkkqruQv tawcfndcUr/AUExBrPR543Bv/WIew== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudegkedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtjeenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepieduueejhfeufeffffffkeeitdfhleeuffeulefhkeehueejffefgffh ffffteffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Sep 2021 20:01:55 -0400 (EDT) Date: Mon, 13 Sep 2021 17:01:53 -0700 From: Andres Freund To: Stephen Frost Cc: pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Deduplicate choice of horizon for a relation procarray.c. Message-ID: <20210914000153.vpuglpeeufomskjn@alap3.anarazel.de> References: <20210827224639.GX17906@tamriel.snowman.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210827224639.GX17906@tamriel.snowman.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2021-08-27 18:46:39 -0400, Stephen Frost wrote: > * Andres Freund (andres@anarazel.de) wrote: > > As the code in question was only introduced in dc7420c2c92 it seems worth > > backpatching this change as well, otherwise 14 will look different from all > > other branches. > > Interestingly, these patches ended up actually introducing a difference > between 14 and master in the form of: > > GlobalVisTestFor(Relation rel) > > - GlobalVisState *state; > + GlobalVisState *state = NULL; > > being done on master but not in the 14 stable branch, leading to, at > least for me: > > .../src/backend/storage/ipc/procarray.c: In function ‘GlobalVisTestFor’: > .../src/backend/storage/ipc/procarray.c:4054:9: warning: ‘state’ may be used uninitialized in this function [-Wmaybe-uninitialized] > 4054 | return state; > | ^~~~~ > > Seems like we should include that change in 14 too, to get rid of the > above warning and to make that bit of code the same too..? Done! Stupid oversight :( Greetings, Andres Freund