Date: Thu, 16 Sep 2021 22:03:05 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@lists.postgresql.org,
	Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Message-ID: <202109170103.qbjmwwvokbfl@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YUPlCVfPi1urH/iN@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/202109170103.qbjmwwvokbfl%40alvherre.pgsql>
Precedence: bulk

On 2021-Sep-17, Michael Paquier wrote:

> On Fri, Sep 17, 2021 at 08:08:44AM +0900, Michael Paquier wrote:
> > I am not completely sure what's going on here yet, so I'll just switch
> > the test to be skipped when Msys is involved for now.  That should be
> > enough to bring back those machines to green.
> 
> So, after drinking down a coffee, I have remembered the difference
> between the Msys and native perls when it comes to IPC::Run:
> - Msys perl generates \r\n.
> - Native perl generates \n.

Yeah, we've been here before -- see 015061690c65 and the commits
referenced there.

> We have already a couple of places where we filter that out, like
> PostgresNode::psql or slurp_file.  But we are missing some spots
> before calling like() for outputs generated by IPC::Run.  I have 
> tracked all those places with the attached, and I think that this
> should take care of the failure seen here while preventing future
> problems.

Looks reasonable to me.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"¿Cómo puedes confiar en algo que pagas y que no ves,
y no confiar en algo que te dan y te lo muestran?" (Germán Poo)