Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWgC5-0005Yc-Ei for pgsql-hackers@arkaria.postgresql.org; Sat, 02 Oct 2021 14:40:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mWgBY-00050F-TW for pgsql-hackers@arkaria.postgresql.org; Sat, 02 Oct 2021 14:40:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWgBY-000507-Ln for pgsql-hackers@lists.postgresql.org; Sat, 02 Oct 2021 14:40:20 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWgBU-00017P-Qi for pgsql-hackers@lists.postgresql.org; Sat, 02 Oct 2021 14:40:19 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 1682932009E5; Sat, 2 Oct 2021 10:40:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 02 Oct 2021 10:40:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=P9Kat61P8ECgzKgJrs4s0cAvZ5qWcOcLMBqK+YxYDh8=; b=HRONypm8 dOLjjjn1LGPGXiKIXjZK6RfSmMWJ9WciKYAHsZGwdnenyIktf5PGZ00HaA5CRLNe 1TlDBVKaxj9wRj8PpuYYZ+1NLrk/XRSV1HunOuglKQ2jqeK3UfgSy+oeqjE4Hhe0 6N3jCVQumcV/KnILI+IX2fULbiGWvqA1TJAJr/t/jmGtx0hLVzF6GW942liykEV+ SWtOSJ1PkJpHJTwX5VX0fZJAzr1p31cTzPIARsapSOETY9t9TA8fg9pWbaoeU4ci 7CkkB6yO72VjAEVw2KMslnezgqO7frUwKJW/77h6CW6UHNKfhXJcmao+fZo1CBQg jOAcvzIR21ym4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekkedgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedujeevjeffjeevuddutedvkeeiueeitddvieelfeekveej udefgeeuvdejhfeuleenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 2 Oct 2021 10:40:14 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 9D6372A08DD; Sat, 2 Oct 2021 11:40:10 -0300 (-03) Date: Sat, 2 Oct 2021 11:40:10 -0300 From: Alvaro Herrera To: Dilip Kumar Cc: Amit Kapila , Robert Haas , PostgreSQL Hackers Subject: Re: pgsql: Document XLOG_INCLUDE_XID a little better Message-ID: <202110021440.hepk6kcgtjzi@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Oct-02, Dilip Kumar wrote: > I have written two patches, Approach1 is as you described using a > static boolean and Approach2 as a local variable to XLogAssembleRecord > as described by Amit, attached both of them for your reference. > IMHO, either of these approaches looks cleaner. Thanks! I haven't read these patches carefully, but I think the variable is about assigning the *subxid*, not the topxid. Amit can confirm ... -- Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/ "Aprender sin pensar es inútil; pensar sin aprender, peligroso" (Confucio)