Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYc30-0005NL-Om for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Oct 2021 22:39:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYc2y-0008O7-ED for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Oct 2021 22:39:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYc2x-0008Nz-K1 for pgsql-hackers@lists.postgresql.org; Thu, 07 Oct 2021 22:39:28 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYc2t-00051v-7c for pgsql-hackers@lists.postgresql.org; Thu, 07 Oct 2021 22:39:26 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 071173201134; Thu, 7 Oct 2021 18:39:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 07 Oct 2021 18:39:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=2DhRnLZ1iIw1Ee6skEPvdNK7c7r4xkQ6ErioegFZG4U=; b=Ouyq4B+l 5aksU5v2AsDhnzRnm2s+FhbuKedR3IpLx1gVmkyOFc3zUNyneh47+1IBx8Hg3FPF Q6g0hihi6i2+r32ddNePLX9yTOXHJoQ9jdOal6izzb7mPb6dRWDRDdQSdV2r8tbt l4MAgKoHmc0mK0Vi0j0CzA9g13mewk+2jbe1GxzyvF+1fyJNOPzl1cG+RmBKo36J 5td8DEXwQfKwUbNZhuoDmtl9Pue1do2Dr4nkJrKr5O0B4weXC+5kZPB+hVq5ASLD ZVn2zOFbvgJljXUhZwANKFugdLIFtFWaA5YUtqb1vMPY2navDPYxlv9zmwPyFJyp cvlC0eTtV04Wlg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelledgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedujeevjeffjeevuddutedvkeeiueeitddvieelfeekveej udefgeeuvdejhfeuleenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Oct 2021 18:39:19 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 589D32A06D7; Thu, 7 Oct 2021 19:39:17 -0300 (-03) Date: Thu, 7 Oct 2021 19:39:17 -0300 From: Alvaro Herrera To: Tom Lane Cc: Daniel Gustafsson , Postgres hackers , Craig Ringer , Noah Misch Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. Message-ID: <202110072239.qh4b5yzcdoy5@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <179777.1633643325@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Oct-07, Tom Lane wrote: > +Portability > +----------- > + > +Avoid using any bleeding-edge Perl features. We have buildfarm animals > +running Perl versions as old as 5.8.3, so your tests will be expected > +to pass on that. > + > +Also, do not use any non-core Perl modules except IPC::Run. Or, if you > +must do so for a particular test, arrange to skip the test when the needed > +module isn't present. If unsure, you can consult Module::CoreList to find > +out whether a given module is part of the Perl core, and which module > +versions shipped with which Perl releases. LGTM, thanks. -- Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/ "Find a bug in a program, and fix it, and the program will work today. Show the program how to find and fix a bug, and the program will work forever" (Oliver Silfridge)