Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYg4K-0007xt-QZ for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 02:57:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYg4J-0007KZ-IH for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 02:57:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYg4J-0007KQ-25 for pgsql-hackers@lists.postgresql.org; Fri, 08 Oct 2021 02:57:07 +0000 Received: from mail-qv1-xf34.google.com ([2607:f8b0:4864:20::f34]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mYg4F-0006xN-RL for pgsql-hackers@lists.postgresql.org; Fri, 08 Oct 2021 02:57:05 +0000 Received: by mail-qv1-xf34.google.com with SMTP id j12so5511616qvk.12 for ; Thu, 07 Oct 2021 19:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mPVP/hZIUu/PgWZIY0HFl1hOwZmQ6pAGDuzYPIzD5Eo=; b=dsEhWwWXdDYYuckwzHN/1M+cP+mBxo6k/DJXsLMBvFhgj1AxDKfqPucttGdXHpcsZj azoYJicoB5pQfJoIBOeshojW4SxEO0srSUq1EfhKZBMZ30IBZQQrrL4ekNTqmMbPKHDM CXboU2AUbQHsgCNyW9qDeib4cZCyptCQvzuvY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mPVP/hZIUu/PgWZIY0HFl1hOwZmQ6pAGDuzYPIzD5Eo=; b=CBmGOcRbrttH5PmPMxuP9luQJ3ngzWrvX9EW+t5R8qkQxquEy0YG0ZTwg/XvDuRFVC 6Ri9lHySoUWIhU/b74mdi6nYUL9bd2MF8vbybEqNIJLm1OwsQeVVwjYg+KQBnAAfmNUc q7YyVF5e0T/1VqdRRjJNpyQXyun8e3cGix4p6lFjOXm6woNJzW2aV0oGLUZEIlfrmjAC Mbc/9JFu9tSoe/+iVODusUJADeNO5XZXU0cqbWQwgtU75DjeNySe/xgjTwUwvtZfBYQw f1HSufa9RM2Expv9U6Dbt92MJkbPLSjmPAfAB/aUZd/FDX9PCCB76U1RU2szXFuH+TCu lmFw== X-Gm-Message-State: AOAM531Y7Tx82u2PDFKU8I8rgYYQ1WumWZp2GlYEV5T0IWIToGXrP+1l 0R6TokR+bEivXyKBpxtk82rFHg== X-Google-Smtp-Source: ABdhPJztxT7vhm7kGxGYoC8h4C1OK8m+bey5cYZCiw58/SgG7DytBLbsYPUzBPL40R6jSKSx2mv+6g== X-Received: by 2002:a05:6214:708:: with SMTP id b8mr7857649qvz.44.1633661822796; Thu, 07 Oct 2021 19:57:02 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::46]) by smtp.gmail.com with ESMTPSA id m68sm1064463qkb.105.2021.10.07.19.57.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Oct 2021 19:57:02 -0700 (PDT) Date: Thu, 7 Oct 2021 19:56:59 -0700 From: Noah Misch To: Tom Lane Cc: Daniel Gustafsson , pgsql-hackers@lists.postgresql.org, Craig Ringer Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. Message-ID: <20211008025659.GA398563@rfd.leadboat.com> References: <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <173186.1633635888@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Oct 07, 2021 at 03:44:48PM -0400, Tom Lane wrote: > [ cc'ing Craig and Noah, as author/committer of the existing text ] > > Daniel Gustafsson writes: > > On 7 Oct 2021, at 21:02, Tom Lane wrote: > >> BTW, looking at that a second time, I wonder if that advice is > >> really of any use. > >> > >> (1) I'm distrustful of the idea that perl 5.8.x will compile > >> cleanly, or at all, on modern platforms. Certainly Postgres > >> releases of similar vintage won't. perlbrew uses the patchperl system to build old Perl in modern environments. This year, I used it to get 5.8.0. Building unpatched 5.8.0 does fail. > >> (2) Unless perlbrew.pl is doing something a lot more magic than > >> I think, you're going to end up with current-not-historical > >> versions of whatever it has to pull from CPAN. That's going > >> to include at least IPC::Run and Test::More if you want to run > >> our TAP tests. Yes. If someone changed the recipe to install Test::More 0.87 and the oldest-acceptable IPC::Run, we'd detect more portability problems. I'd regard such a change as an improvement. > >> So maybe this advice is helpful, but I'm not very convinced. The rest of this thread is leaning on the above misconceptions: > I propose that what might be more useful than the existing last > section of src/test/perl/README is something along the lines of: > > Avoid using any bleeding-edge Perl features. We have buildfarm > animals running Perl versions as old as 5.8.3, so your tests will > be expected to pass on that. > > Also, do not use any non-core Perl modules except IPC::Run. > Or, if you must do so for a particular test, arrange to skip > the test when the needed module isn't present. -1. This would replace a useful recipe with, essentially, a restatement of that recipe in English words. That just leaves the user to rediscover the actual recipe.