Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYhUu-0003Wv-Q5 for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 04:28:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYhUt-0002sU-QQ for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 04:28:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYhRQ-0002Ep-Vk for pgsql-hackers@lists.postgresql.org; Fri, 08 Oct 2021 04:25:04 +0000 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mYhRK-0007jL-O9 for pgsql-hackers@lists.postgresql.org; Fri, 08 Oct 2021 04:25:03 +0000 Received: by mail-ot1-x333.google.com with SMTP id c26-20020a056830349a00b0054d96d25c1eso10161218otu.9 for ; Thu, 07 Oct 2021 21:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cbBdsMnxAyuubvmjXI5gUaa7wI3sC87O6NeJB9sESIs=; b=CAggHhEHAqUbLNAP1Ja7bXtGFDw0HYv/wm23LqS7PoWFtA7G47/H4dKX2BtoEYLYY0 6aoxmYqsuAGoqmGB1JM/8IAg9DiBWBK4EqfxoMp0HFaK2Lh1VYDc+PosYstdhxs19AO2 NSdEIMRP3bJnpKDv8z7cLIZPwl1lVq5skoMkc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cbBdsMnxAyuubvmjXI5gUaa7wI3sC87O6NeJB9sESIs=; b=D78b8oEMc4EIfxcNODwnZ3De2NOGdFP9W5N7AG3EQoWk1Pvby3m9v2ElIiURmIQnoX aBCx7jM+wi91ViAsGy/eNfXvZ3AjmayS8/t/UuBrWpi7wNWPVJkhLfeMSIfleuLUNLu6 8DGXt650Zo0IcTkEf0jhmIN4WQcaECEoG9CIjPSuHyHZb+mMidw19JhQ623x7gEHx3PH fSoxtX86dflji/bMo28WpfjJkXJrJWLIzvBJrvN9MpImH+al1btCxrbo8lB7U9ntEjv/ w1ZCwmD4ewwrQXdmgE7tRC2OSJ5EnVnCY8/1cGM3yplxRDsZLd2ZA3B+TXqQ8u2PoJ/F QcYg== X-Gm-Message-State: AOAM533FDGKhyllPUM/HfEcaYsBkuUbIxUM7eXRboLU3AejHtYSjT5Zz XQ8yYiyV1nfkPkpv6z6ChkL5c+eiYJFa/g== X-Google-Smtp-Source: ABdhPJzZgySedluSSM4ZMMBjaEP97YiAH4vT0xUrM6xMUFVmNZXW2dI6pMht+xXpIas0yiIrtkgi1g== X-Received: by 2002:a9d:600d:: with SMTP id h13mr6745787otj.265.1633667097544; Thu, 07 Oct 2021 21:24:57 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::46]) by smtp.gmail.com with ESMTPSA id e2sm266950ooh.40.2021.10.07.21.24.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Oct 2021 21:24:56 -0700 (PDT) Date: Thu, 7 Oct 2021 21:24:54 -0700 From: Noah Misch To: Tom Lane Cc: Daniel Gustafsson , pgsql-hackers@lists.postgresql.org, Craig Ringer Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. Message-ID: <20211008042454.GB398563@rfd.leadboat.com> References: <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <197091.1633664351@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Oct 07, 2021 at 11:39:11PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Thu, Oct 07, 2021 at 03:44:48PM -0400, Tom Lane wrote: > >>> (1) I'm distrustful of the idea that perl 5.8.x will compile > >>> cleanly, or at all, on modern platforms. Certainly Postgres > >>> releases of similar vintage won't. > > > perlbrew uses the patchperl system to build old Perl in modern environments. > > This year, I used it to get 5.8.0. Building unpatched 5.8.0 does fail. > > Oh, cool. > > >> I propose that what might be more useful than the existing last > >> section of src/test/perl/README is something along the lines of: > > > -1. This would replace a useful recipe with, essentially, a restatement of > > that recipe in English words. That just leaves the user to rediscover the > > actual recipe. > > Well, I think the existing text does the reader a disservice > by stating a specific recipe without any context. Notably, > it says nothing about restricting which Perl modules you use. That's obvious from "cpanm install IPC::Run". Surely if any other non-core module were allowed, the recipe would list it in a similar way. This is a source tree README; it shouldn't try to hold the reader's hand like the user-facing docs do. We've not had commits add usage of other modules, so there's no evidence of actual doubt on this point. > What do you think of using my proposed text followed by > > One way to test against an old Perl version is to use > perlbrew. > << more or less the existing text here >> > Bear in mind that you will still need to install IPC::Run, > and what you will get is a current version not the one > distributed with Perl 5.8.3. You will also need to update > Test::More because the version distributed with Perl 5.8.3 > is too old to run our TAP tests. So this recipe does not create > a perfect reproduction of a back-in-the-day Perl installation, > but it will probably catch any problems that might surface in > the buildfarm. I don't see an improvement in there. If there's something to change, it's improving the actual recipe: --- a/src/test/perl/README +++ b/src/test/perl/README @@ -83,3 +83,4 @@ Just install and perlbrew install-cpanm - cpanm install IPC::Run + cpanm install Test::More@0.87 + cpanm install IPC::Run@tbd_old_version