Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYxCP-0002L4-RK for pgsql-committers@arkaria.postgresql.org; Fri, 08 Oct 2021 21:14:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYxCO-0000wx-LY for pgsql-committers@arkaria.postgresql.org; Fri, 08 Oct 2021 21:14:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYxCM-0000wp-Oh for pgsql-committers@lists.postgresql.org; Fri, 08 Oct 2021 21:14:36 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYxCJ-0007CF-Fv for pgsql-committers@lists.postgresql.org; Fri, 08 Oct 2021 21:14:33 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 741CC3200AF0; Fri, 8 Oct 2021 17:14:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 08 Oct 2021 17:14:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=uy/YvU4HmmPJ3JsFW2StrYmL7HF 8izDS2f64WUJ9IGg=; b=wvSSX2GRUndCU8OLUYcEac9Miv7y8BFQT5paKkYDSk/ B9hr10eIrxF5wXaKux9so/UEUHweCZkjJ79GMbSPd9X2KmCaHika4ntlXGdDLJFw R18W0GOpOBZ4b1pMBJD8Da1fVVWHhBoY2heugzBzia09qNO9vnwOl616ByXb+1Y5 A2os7PQbszZu+RODV36LE76fV5yssn+3LFGWfpDBRXei8ehb7biLIKCcTqwMrVpp CLvUx8huOL3HF3n6Kc0mT+zQSaFdm6rXDJvcoDVpDbHUWj03dN7gXXANpjZsAhlK gE27lLBU/WXavdF1Kzzzb4o2HH2OhnBc5sHvJc5Z7UA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=uy/YvU 4HmmPJ3JsFW2StrYmL7HF8izDS2f64WUJ9IGg=; b=JcLgqWDFbAFOfQ7MFj4EQp yOHOV2VKlFZer5xvq0/28tPuqgJ1NcgYHjNooOjYdbW/1Ql8yoQRx8i0M16IW6qm xeW/wm3e+haWTzAhx+/DbVrI3Mnug9uDKFykLypwvgHMlvsouolp8rtZdOoZtxKg T0YCP59FW7QC+ZZ4Iw0BKNtHXKhFiB6Vv9PUMuEXhEKCLNk6GoAoiIrb9/soSbai N/H7UvMwQGWJtdO8m7UJBp08ZJzEYjJFpmobttsABl32JQh5D38LV+kslNhiC7Jb X6m+r1bGaqYrk6zOCJsu3UVeEoDHLEzhBwW3R7EnaV61jk5GYTQhcVu/xDclYXPg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddttddgudehiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepffdvvdevleelgffhheeitdevhfefgfeivdevieeltdffkeefgffguedt keeiheejnecuffhomhgrihhnpehpohhsthhgrhdrvghsnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgriigvlhdr uggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Oct 2021 17:14:28 -0400 (EDT) Date: Fri, 8 Oct 2021 14:14:27 -0700 From: Andres Freund To: Andrew Dunstan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl. Message-ID: <20211008211427.e2j2f3vnhjd3peda@alap3.anarazel.de> References: <4941f5a5-2d50-1a0e-6701-14c5fefe92d6@dunslane.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4941f5a5-2d50-1a0e-6701-14c5fefe92d6@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2021-10-08 11:41:50 -0400, Andrew Dunstan wrote: > On 10/1/21 6:34 PM, Andres Freund wrote: > > Reference test binary using TESTDIR in 001_libpq_pipeline.pl. > > > > The previous approach didn't really work on windows, due to the PATH separator > > being ';' not ':'. Instead of making the PATH change more complicated, > > reference the binary using the TESTDIR environment. > > > > Reported-By: Andres Freund > > Suggested-By: Andrew Dunstan > > Discussion: https://postgr.es/m/20210930214040.odkdd42vknvzifm6@alap3.anarazel.de > > Backpatch: 14-, where the test was introduced. > > > > I don't think any of us were thinking very clearly about this. Of > course, MSVC doesn't build executables in $TESTDIR. If we want to pick > up the executable from where it's built we'll need a little help from > vcregress.pl. I haven't tested it but What I have in mind is something > like the attached. Hm. Clearly this needs more work. But I don't really like having checks for MSBUILDDIR in individual tests - we should do this somewhere more central. Afaictl the windows build just installs libpq_pipeline.exe. If we make sure that on !msvc builds CURDIR is on PATH and on msvc temp_install/bin/ is on PATH (which it should already be), then we should be good? I guess the reason this didn't work for me before was that I invoked install.pl from the top directory, which then didn't install libpq_pipeline.exe, because of the config.pl issue I mentioned somewhere? Greetings, Andres Freund