Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZHwk-0004c7-Gf for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Oct 2021 19:23:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mZHwj-0005H4-1U for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Oct 2021 19:23:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZHwi-0005Gw-He for pgsql-hackers@lists.postgresql.org; Sat, 09 Oct 2021 19:23:48 +0000 Received: from mail-oo1-xc32.google.com ([2607:f8b0:4864:20::c32]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mZHwc-00050U-9l for pgsql-hackers@lists.postgresql.org; Sat, 09 Oct 2021 19:23:47 +0000 Received: by mail-oo1-xc32.google.com with SMTP id c29-20020a4ad21d000000b002b6cf3f9aceso800310oos.13 for ; Sat, 09 Oct 2021 12:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GOs3Kjwkn+Mj34Yrqa6Jo+lskjwh5RTWiRgL59LJHZ8=; b=J+/s+8jdwgbqnBCgagKOTUeqssgFfo5cCVkNT5iUAPjaPSrEDqoEjYJzSqzzk2UT38 IRGT4G/bMEffs3j8gUBVGIF3xIkL/mDitaOcx1jph+Q5cgcUuFkn+NmE/6H9W+KcrhOO f6b6X8kH2G/0+FBzSUS7JMx71xSXY/9CXkmao= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GOs3Kjwkn+Mj34Yrqa6Jo+lskjwh5RTWiRgL59LJHZ8=; b=8OK7EnXPQLpixcTstcaVYE/q9W7siZY2abXaDbrxvRRUe35OJ8m9/RbvI6Gir14p/y 2OXLQt5RzJcJh77XDQ3LxME7lDg3/v1Htr92PBwjzpsb242MDgwuap0k9G8felQ45CYw RGsk1UBJJZ7HBGic0ZBIjYSZEQqQbA2/N0LZFa3bXL28e3wGlMinO5jONYdTtFPCQkge 1uEu52weq3j6Lt39gEKIKGgOXJ2HbhcmXVVSUx6crJKoiZs+LkO+t5MbxkTxittMvAaQ r7ZAoGmD5KdkF2ZllAoLz3RjFT7i5wGkBHDLjPvNkfweIJJxs0GHjDo0BoIAOBzdNh/V sYaQ== X-Gm-Message-State: AOAM533UpByUcAJlhl12dyAnbRkIZB4M34VNBAHTC+ck3S8pNzYgOG5j EsiY36EhWy5FgyMlJwJ4p1Byt8sDrzlCRg== X-Google-Smtp-Source: ABdhPJyVij9MmC+IQO6r/F14m3HNY1d4fmsqcZ0NXJHp7slsd1RrVGZvTBGzUpMP2KGaj0yu0NczUg== X-Received: by 2002:a05:6820:60e:: with SMTP id e14mr13112263oow.49.1633807419972; Sat, 09 Oct 2021 12:23:39 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::46]) by smtp.gmail.com with ESMTPSA id d10sm599221ooj.24.2021.10.09.12.23.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Oct 2021 12:23:38 -0700 (PDT) Date: Sat, 9 Oct 2021 12:23:33 -0700 From: Noah Misch To: Tom Lane Cc: Daniel Gustafsson , Postgres hackers , Craig Ringer Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. Message-ID: <20211009192333.GA450252@rfd.leadboat.com> References: <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us> <20211008042454.GB398563@rfd.leadboat.com> <03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se> <234637.1633709021@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <234637.1633709021@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Oct 08, 2021 at 12:03:41PM -0400, Tom Lane wrote: > Daniel Gustafsson writes: > > On 8 Oct 2021, at 06:24, Noah Misch wrote: > >> That's obvious from "cpanm install IPC::Run". Surely if any other non-core > >> module were allowed, the recipe would list it in a similar way. > > > The proposed changes talks about with core modules are allowed to use, I think > > that's a different thing. The distinction between core and non-core modules > > may not be known/clear to people who haven't used Perl in the past. > > Yeah, I don't really think that this recipe makes it plain that we have > a policy. It certainly fails to explain that you're allowed to use > additional modules if you're willing to skip the relevant tests. True, +1 for mentioning that tests can use less-available modules if they skip when those modules are absent. I'm only -0 for adding the other English (unlike the -1 for the original proposal of removing the shell commands). > >> If there's something to change, it's improving the actual recipe: > > > That we should do as well. > > You're not going to get far with "improving the recipe", because it's > just not possible. To check this, I installed perlbrew on a Fedora 34 Your test result is evidence that "cpanm install Test::More@0.87" is the wrong shell command, but it's quite a leap to "just not possible". Surely there exist other shell commands that install http://backpan.perl.org/modules/by-authors/id/M/MS/MSCHWERN/Test-Simple-0.87_03.tar.gz. (Perhaps none of us will care enough to identify them, but they exist.) By the way, I suspect 93fb39e introduced a regression in the recipe. (I haven't tested, though.) Before commit 93fb39e, "cpanm install IPC::Run" would update Test::More. As of 5.8.3, the core version of Test::More is new enough for IPC::Run but not new enough for PostgreSQL. I recommend adding "cpanm install Test::More" to restore the pre-93fb39e functionality.