Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcTYW-0000vm-2y for pgsql-committers@arkaria.postgresql.org; Mon, 18 Oct 2021 14:24:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mcTYT-0005VU-T0 for pgsql-committers@arkaria.postgresql.org; Mon, 18 Oct 2021 14:23:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcTYT-0005VL-Mf for pgsql-committers@lists.postgresql.org; Mon, 18 Oct 2021 14:23:57 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcTYP-0005aG-2A for pgsql-committers@lists.postgresql.org; Mon, 18 Oct 2021 14:23:56 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C14DE5C01AA; Mon, 18 Oct 2021 10:23:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 18 Oct 2021 10:23:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=oXc+0beNIK886+Tvke8/1xiuRxWi3jIRZvbMP9NobUc=; b=W3mZBIev PIBIj2Kk9EFTQkmAOv3zckDd37Jvrl0X2QAb0hb8i5DoQl0wyBaZjGoc6x327Yxp OOtp+bHIyE2BRyfOorULfjr9SP6TN1ruvhjrR8nuMIgYDjA8TBjbYbwl3VmlId5A lCz+HjPWZL6WeKTaaSnBXHGNKgTJ39cdmnkcZY829aDPgr1hKQEEa82Mmt0diPvX ugiZIxVrHqLLFInKcarp5Gwwb8HA9bF9Dvdd1MhIWD+hnI7O8NTNewTnIbZbdKol sOL+2p9WssFvgtL6UJoGVhKuoDnTJdW633V/3yF4+09+JZ1dhzI8FTtk9vuU5lrj EpSuOSGnAVIIXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvtddgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedujeevjeffjeevuddutedvkeeiueeitddvieelfeekveej udefgeeuvdejhfeuleenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Oct 2021 10:23:50 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 668862A06AD; Mon, 18 Oct 2021 11:23:48 -0300 (-03) Date: Mon, 18 Oct 2021 11:23:48 -0300 From: Alvaro Herrera To: Andrew Dunstan Cc: Andres Freund , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl. Message-ID: <202110181423.cmd34pruwlry@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Oct-17, Andrew Dunstan wrote: > +sub find_built_program > +{ > + my $program = shift; > + my $path; > + > + if (defined $ENV{MSBUILDDIR}) > + { > + # vcregress.pl sets MSBUILDDIR which is the root of all the build dirs > + my $wanted = sub { $_ eq "$program.exe" && $path = $File::Find::name;}; > + File::Find::find($wanted,$ENV{MSBUILDDIR}); > + } Hmm, it seems weird to have to use File::Find when we already know where the program is, right? I mean, per your previous patch, we know that the program is in $MSBUILDDIR/libpq_pipeline/libpq_pipeline.exe, so why don't we make this one be if (defined $ENV{MSBUILDDIR}) { return $ENV{MSBUILDDIR} . "$program/$program.exe"; } ? I noticed that drongo is still red, and reporting that no tests are being run. While this makes sense (because the list of tests is obtained by running libpq_pipeline), I am surprised that this isn't reported as such. I would have expected it to die with an error message starting with "oops: " ... did run_command() fail to return stderr? ... oh, run_command() seems a bit too optimistic: it doesn't check whether IPC::Run::run() failed. I think that's worth fixing independently. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ Subversion to GIT: the shortest path to happiness I've ever heard of (Alexey Klyukin)