Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfpve-0003h6-5n for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 20:53:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mfpvc-00072m-Na for pgsql-committers@arkaria.postgresql.org; Wed, 27 Oct 2021 20:53:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfpvb-00072b-Bs for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 20:53:44 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfpvU-0001BW-92 for pgsql-committers@lists.postgresql.org; Wed, 27 Oct 2021 20:53:42 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EB0255C018F; Wed, 27 Oct 2021 16:53:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 27 Oct 2021 16:53:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=QTh0dD/iQngclcIbJHEvChuhTRk LwCSpBpWgU6jIDiw=; b=nj/D4kgP9UGRAvIyPUfMRFYro2zGVEEBUttLz36hKXM 4W+77YVuRtuuZIURdLWaemOc7Z7GKkFZFo+KBYNY9ZOCn423ia91jTwjMNnUqoqE QOH13KkB3PFpcQqF5upAaVtlPHTgy+mHoIyJnadRrRSXJ8W+k4wv2aQWGp9ja40T TUS9KkcxZMwgPMD/lQQAgoIBAI+y6FRVMGNBe4RM/XxIG2Vpz7RsXlC0tk2EUDgw J1sD5DURJmRGlMP2eH1Kld5SgnMISPpWvudLK090WvBYMKhaWuZ6MMs/x6hC1jFi 673nspqZjQObsQsPtuOBED7214QJBTvkDOomswHmwVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=QTh0dD /iQngclcIbJHEvChuhTRkLwCSpBpWgU6jIDiw=; b=JELVjeS1Fh8N7m2iCMftJB SRmvx0/mfss+ztJHEOKZF8eS9XbwZqbeX0PJXXqVUxqVXU+8BSg6RB8LSiuYgwLJ pCbvxAANEMkigpFYZw7m5qqiDrrkaCjZ0SzwWp/BPxsvnMuVy1fSSlfB8CmYs8Qq 18G0GmrOax2xTg6WkMV3EoYfNsTvrHmN/FjJTtYDJVWQc52UOfiE+QR4mmCIpDlY HL7QweXvBBWf/RyNEaGEtjqPh1EAkaydV1XLpaj/3JU+65L92mT3U3/8TGERrqO/ DDZkdmUSybOS0CGOw+GARt4tEP2Pb4+1GBbB6CbT9B/Ycv1tgmtam2p8hzEfG42A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdegtddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeff hfeuffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 16:53:33 -0400 (EDT) Date: Wed, 27 Oct 2021 13:53:32 -0700 From: Andres Freund To: Daniel Gustafsson Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Refactor the sslfiles Makefile target for ease of use Message-ID: <20211027205332.dp22qru3n25g7kyn@alap3.anarazel.de> References: <20211026174152.jjcagswnbhxu7uqz@alap3.anarazel.de> <7614BC3D-0B3B-4D9C-8801-D771042EF2B4@yesql.se> <387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk i, On 2021-10-27 21:57:42 +0200, Daniel Gustafsson wrote: > > On 27 Oct 2021, at 16:37, Daniel Gustafsson wrote: > > > >> On 26 Oct 2021, at 19:41, Andres Freund wrote: > > > >> This fails during 'make clean' in a vpath build, because sslfiles.mk cannot be > >> found. Probably just needs > > > > It does in fact need that diff, but sslfiles.mk also needs to be taught about > > the current $(srcdir) to properly function under VPATH for "make sslfiles". I think that may previously also not have worked. I mostly care about getting make clean to work again... > Discussing this off-list with Jacob, and dabbling some more with it, this needs > more thought. It's not clear what make sslfiles should do in a VPATH build, > and where, since the artefacts are both generated and distributed. It's imo pretty clear that it'd need to put the files in the source directory. > I've pushed the small fix to ensure "make clean" works as that's a much more > common usecase, to allow for time to discuss "make sslfiles" on -hackers. Cool! Greetings, Andres Freund