Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjUGX-0001cJ-Qb for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 22:34:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mjUGW-0005RN-PM for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 22:34:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjUGW-0005RD-IC for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 22:34:24 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjUGU-0006gC-8x for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 22:34:23 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 95A0D5C0093; Sat, 6 Nov 2021 18:34:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 06 Nov 2021 18:34:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=+Wge3YmpQdCx3JfXU8CibIEEJqN SPg8jDazES7U15eo=; b=kLEl6rufuQyPe8IOgB1CdUxOyYdfWucMAx1Ie4HWpb1 0dykETycBqwcnurMMgKco3isHPlMcasIFJjgTzvjD3vgtu/quPfQyBv7AvNljizR 85G0clWBUQ4phBMF/6TUwC+2OdCn5aRD0DbPN8MWh2iCfG6A9sLktTn8QRgXwOVa B+7pOHZt8AjFl1eMBjqpXKior6LvMqjgXm5XSH+gUm7YGWn8nn379MvzoUF6D5GL vRbYjehAKd0zMb8+kJI28kirNVwvthHocnEWF8xmml3yS/wd11pFAIZUSIsAPezK cUCLmE2RnDii+nJTc0wXDiV2aEn633L0gSphDujhH4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=+Wge3Y mpQdCx3JfXU8CibIEEJqNSPg8jDazES7U15eo=; b=bSRLdOWD5Ad8VUIKDpBTld 1WLkZ4svTOrYE8gzygSQfglMIcfhIHanJpGVKAHO816UXBCLtsHvxK66Oz+mjEHh yU/BOHrCcfzJUPeIqDHyJTmxm9pekCAbPQefbMEsQo/Bt7cDtB3jFWheQtoopfNh YF1JB0CjpHdfdCsxq71mJp8Pi6Vxe8rs5HofFvSmH0nO7lPRAFAGuHzKzJH477pc jmg2Xx9yWh36bFjydgRz9gKuMDsQeJJXK7G700smAL4haiUZOLGOAufl+wD3W3di 4LobVogKVCkBjybvlPi5lWVyCpquKWx6ZGLI/Dus5Y8ENz/rKFJ1pv7IxejLKpsQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdekgdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpeevhfejveehvddvgfdtueefuefhhfetkefgfedtkefhieeuudefveduffdu gfdvgeenucffohhmrghinheptghirhhruhhsqdgtihdrtghomhenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghrrgii vghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Nov 2021 18:34:21 -0400 (EDT) Date: Sat, 6 Nov 2021 15:34:20 -0700 From: Andres Freund To: Tom Lane Cc: Peter Eisentraut , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: pgcrypto: Remove non-OpenSSL support Message-ID: <20211106223420.xfnbfiwhcxhfwiam@alap3.anarazel.de> References: <20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de> <611793.1636236429@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <611793.1636236429@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2021-11-06 18:07:09 -0400, Tom Lane wrote: > Andres Freund writes: > > This appears to have broken msvc pgcrypto being tested with msvc. I think > > that's because pgcrypto is still listed in the "base" @contrib_excludes and > > thus just isn't getting built anymore, now that the special-case build rule is > > gone? > > I came to the same conclusion and pushed that change. We'll soon > see whether it's sufficient. It was sufficient. The tests are still running, but the pgcrypto test just passed (see contribcheck_test): https://cirrus-ci.com/task/6128369478664192 vs previous run before rebasing: https://cirrus-ci.com/task/5856750176829440 This is the meson branch, but testing the src/tools/msvc style build. Greetings, Andres Freund