Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjUNm-0001vc-Rd for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 22:41:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mjUNl-00006Q-Kg for pgsql-committers@arkaria.postgresql.org; Sat, 06 Nov 2021 22:41:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjUNl-00006D-Dz for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 22:41:53 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjUNf-0006jA-6I for pgsql-committers@lists.postgresql.org; Sat, 06 Nov 2021 22:41:52 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 68EFB5C0061; Sat, 6 Nov 2021 18:41:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 06 Nov 2021 18:41:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=Ha01z6tlIoB1HmMIqJFckJWyZeI oZdAaaWQW1IvZewI=; b=h1q9IrCRCZPHyGVFbt1zgZjASrWhYGKKTyNOxW2oYBK XbBY+kI/KRWVmNlACne7Z+1MSeVTSO8yshmS8Y+zybqCU6ve7aZ//O4Pgrd6Lk2t Ws7dQj09Y/XVOa3xsxvKWLb/wXanuSt0V5FKyS+migwAO1XYES5J6YZMu/HBdf4K GqDyCChSDiCxAChUwSMgVUzmR4kS9O5tF5jrDoaowow/U7LP2/3kS1I0Xb/yXmtj 86pZPl1z8GYKadU2zkJUwQDDpu5AbohPDktnkVivYMsDrGNNTviynck95R0UJOSP 6BOHS4vkIwnxQ1L0Yci/+3HXoSHQX51dc1G5H8+8a+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Ha01z6 tlIoB1HmMIqJFckJWyZeIoZdAaaWQW1IvZewI=; b=LbN8+fFgQLJRE0OXb9IHXW uSddR3nPFtr4ph9oAlkrL1uP9bXrlsM63ImqdmAfwABO77N+MoZQQxZIGUbCfXPO pQXkyAsjCVsgjULKVguoHwde8v+fdiry3Xc8WdndkOz+HI9u1FM/YwViBMHdEef/ gCa13fWhQrMIllxkfkA7clmIHoqPX336MVv8D4zGOL0zkMdJATWkZ27HL9bHlhhy dCYk5UuHZT+7D1KbKmRwQ6SNAnNeOqX6qeEnPpbi1YySDa51ly6fl1I2WoiNVSJw Vq5h2yUMAAhRUxW5H0lnWFlTcFDO57VAARJo2BN1YxwA+w9C9gN4TF93qcprUyBw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdekgdduiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghn rghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhepudekhfekleeugeevteehleffff ejgeelueduleeffeeutdelffeujeffhfeuffdunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Nov 2021 18:41:46 -0400 (EDT) Date: Sat, 6 Nov 2021 15:41:45 -0700 From: Andres Freund To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. Message-ID: <20211106224145.ujges4hs7tyqglp7@alap3.anarazel.de> References: <612842.1636237461@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <612842.1636237461@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2021-11-06 18:24:21 -0400, Tom Lane wrote: > Andres Freund writes: > > windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. > > I happened to notice from grepping that > src/backend/port/win32/crashdump.c has its own > > #define WIN32_LEAN_AND_MEAN > > Can't we remove that now? (I kind of wonder what good it did at all, > considering postgres.h has already pulled in .) Yea, it seems pointless. There's a semi-related weirdness: Several src/port/ files include themselves (I guess that could be seen as prep for dropping windows.h from win32_port.h). Unless you're already done with that by the time I git pull, I'm gonna remove that redundant WIN32_LEAN_AND_MEAN. Greetings, Andres Freund