Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mn1xr-0003WB-Py for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Nov 2021 17:09:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mn1xq-0005vM-E8 for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Nov 2021 17:09:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mn1xp-0005vD-VS for pgsql-hackers@lists.postgresql.org; Tue, 16 Nov 2021 17:09:45 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mn1xn-0001dC-9i for pgsql-hackers@lists.postgresql.org; Tue, 16 Nov 2021 17:09:45 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id A1F9E3201126 for ; Tue, 16 Nov 2021 12:09:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 16 Nov 2021 12:09:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=ivkew+C2dVzfqhvPTdl6mN/QdScdtaD2TRTlaEv9f4I=; b=RVsuQ4nZ wmhzgK3aEm+FZHxOIHjd2cvJXZBCnzl3OwoCA1lanemY4LYVeO32b4uKkG/m3UcG z6qolyUuEDt8/lZ1YqhSQkkJW54IenUa7tWXRF3L3zKJkz/4VFWEJcph9vBD7iCm CyNA3sO7QyGbh7Z3b0I6A00xsqtFHKdbpL4pOqUPoRgwIy7Z019vKf2zlXPUpEVa 0a6fj1JMa6pGnQ10lwo/bJ9teNeHXKLvlzAEoDjbThiDO4Q2kLo36KERoD1WWyUG uxgiC3799SCvAyq4881fRk4hEKr4FNavY5cp57h9I1goTmp1JU8nOuj9aXjE9nIh LI0AG5xX58m9VA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfedvgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggugfgjsehtkeertd dttdejnecuhfhrohhmpeetlhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvges rghlvhhhrdhnohdqihhprdhorhhgqeenucggtffrrghtthgvrhhnpedujeevjeffjeevud dutedvkeeiueeitddvieelfeekveejudefgeeuvdejhfeuleenucffohhmrghinhepvghn thgvrhhprhhishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 16 Nov 2021 12:09:40 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id B72AB2A05A8; Tue, 16 Nov 2021 14:09:36 -0300 (-03) Date: Tue, 16 Nov 2021 14:09:36 -0300 From: Alvaro Herrera To: pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h Message-ID: <202111161709.u3pbx5lxdimt@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Nov-16, Alvaro Herrera wrote: > Fix headerscheck failure in replication/worker_internal.h The other failure is in src/include/libpq/be-gssapi-common.h: In file included from /tmp/headerscheck.a6f0um/test.c:2: ./src/include/libpq/be-gssapi-common.h:20:10: fatal error: gssapi/gssapi.h: No existe el fichero o el directorio 20 | #include | ^~~~~~~~~~~~~~~~~ compilation terminated. One possible solution for this one is to add an exclusion in headerscheck (and cpluspluscheck?); the other possible solution seems to be to wrap the whole contents of the file in "#ifdef ENABLE_GSS". I think the latter is roughly the approach used for OpenSSL inclusions. -- Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/