Date: Tue, 16 Nov 2021 12:14:31 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Message-ID: <20211116171430.GI26257@tamriel.snowman.net>
References: <E1mn1OI-0007WG-H9@gemulon.postgresql.org>
 <202111161709.u3pbx5lxdimt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/8E7gjuj425jZz9t"
Content-Disposition: inline
In-Reply-To: <202111161709.u3pbx5lxdimt@alvherre.pgsql>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20211116171430.GI26257%40tamriel.snowman.net>
Precedence: bulk


--/8E7gjuj425jZz9t
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Alvaro Herrera (alvherre@alvh.no-ip.org) wrote:
> On 2021-Nov-16, Alvaro Herrera wrote:
>=20
> > Fix headerscheck failure in replication/worker_internal.h
>=20
> The other failure is in src/include/libpq/be-gssapi-common.h:
>=20
> In file included from /tmp/headerscheck.a6f0um/test.c:2:
> ./src/include/libpq/be-gssapi-common.h:20:10: fatal error: gssapi/gssapi.=
h: No existe el fichero o el directorio
>    20 | #include <gssapi/gssapi.h>
>       |          ^~~~~~~~~~~~~~~~~
> compilation terminated.
>=20
> One possible solution for this one is to add an exclusion in
> headerscheck (and cpluspluscheck?); the other possible solution seems to
> be to wrap the whole contents of the file in "#ifdef ENABLE_GSS".  I
> think the latter is roughly the approach used for OpenSSL inclusions.

Short answer is yes, inclusion of be-gssapi-common.h is typically
wrapped in a #ifdef, see src/backend/libpq/auth.c

Thanks,

Stephen

--/8E7gjuj425jZz9t
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJhk+b2AAoJEO1sijiDR2RVmUwQAIeUDHrizav08LYSiXS+9D2U
MnoBHcJxpiy7JTE/LB54ON009CX+Ilt/dKdN/9Tcs4OPvl5DqIIuYNOFteYTLVow
tq57pz81D+ax7aQ6SZbYtMkSyMf8SqUoVfEUdgiD5vuOnjwRUyaRpvKhzdqK9M9o
QYpuUdwdaUVzzq033CNWvzqvIHgx6JXCgqI6i+i+Oi0Gdxj/aD0UhUkWxOP4YkeA
rx88LRGtrXWBd6pUbMIizqiwnSr9uTQRB6TcRDftvdJJ/6uFxE1Ckl1PULdLD38P
+F6ZJ84GTEgRJa5Lv30upvLo+V0usmzteXwqpoKzNkLSa3TMw3w3DKG4rKq2caqT
rswVSIJ/TmnP6dRwhNS6G9rW19v05yFiaCKYpdfqWsYjB3f0qfbcBHiUQAN7Uvp7
igTcep/ncNMjCTONw2d12HqS7wiHwVDWHXJVKP4DubTu9tmaZV5vDFHE9vuwCDm0
Cv6g82ETymdgDlQ4PsfRqW47eTAOjPQrV0vXs7UNQ+OguDzM11n8jaJEn/ct7jI+
Jus2SFskgT/mAY57mg/DmctFh6Md/Y/ADvMj26ASrMBHOnCfk3jI77clkM+HA6HA
KDjz43eU898jlhDwbF3pUcwhTlNLlIKEhMXz/8A6hzXTdDH7xHpBaPHdqNFEd/K7
iz7kpJC4gEFs8d/cAaxN
=FJ/1
-----END PGP SIGNATURE-----

--/8E7gjuj425jZz9t--