Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mn30m-00081D-AA for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Nov 2021 18:16:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mn30l-0001Cw-8h for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Nov 2021 18:16:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mn30k-0001Cn-VU for pgsql-hackers@lists.postgresql.org; Tue, 16 Nov 2021 18:16:50 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mn30i-00027m-Mf for pgsql-hackers@lists.postgresql.org; Tue, 16 Nov 2021 18:16:50 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B0B775C0226; Tue, 16 Nov 2021 13:16:47 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 16 Nov 2021 13:16:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=grUd412cTo7m/RJZ+4g3Oiub1gTpxS+3bVilZL6LM68=; b=YT7AkuDA UIPfDeE6NwRj3s9TB+t6o7aBWL2fNz0fkBFPu7T2xHnLIZrMNwvV+WqzgJYrwJcX U+4U+XysfOmwJ9n4SKOloz2SajEb7lYfQKmQ+zNn1g3DYbGmRVWzrhozuQZddOd4 zDcB3gpc3PveOwcxapT6c+8cxPdjrChwiMAEboT0IpP1ah2F2oOonBrM+iV9DiU7 SElQI2T8wvLtgEXwROCMfNaX51VHjgUUQty4ywUq4XmJ2oDjZca1RToHqmxNguwz QFce/xoCytCPIU17NjfIoNb1BXG3HyuXly70CQU5pMzMBTBtdvuBor3omWIvwNom E7UkeXV2k6PNzg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfedvgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedujeevjeffjeevuddutedvkeeiueeitddvieelfeekveej udefgeeuvdejhfeuleenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 Nov 2021 13:16:47 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 134232A05A8; Tue, 16 Nov 2021 15:16:45 -0300 (-03) Date: Tue, 16 Nov 2021 15:16:45 -0300 From: Alvaro Herrera To: Stephen Frost Cc: pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h Message-ID: <202111161816.bncq4ckt6ahl@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Nov-16, Stephen Frost wrote: > Not against possibly changing that but I don’t get the point of including > be-gssapi-common.h if it’s not enabled in the build and typically if GSSAPI > is possible and the reason for including be-gssapi-common.h then there’s > other things that need to be under a ifdef, again, as in auth.c BTW, this is exactly why my first suggestion was to add an exclusion rule to headerscheck so that be-gssapi-common.h is not verified by that script. After re-reading your response, that looks like a reasonable answer too. -- Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/