Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mobNO-0006go-55 for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 01:10:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mobNN-0002uT-1r for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 01:10:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mobNM-0002uK-Qf for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 01:10:36 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mobNG-0000cG-4e for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 01:10:35 +0000 Received: by mail-qt1-x82c.google.com with SMTP id v22so13077587qtx.8 for ; Sat, 20 Nov 2021 17:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MiCKLpNoPWheDzEBeKxzkSAOyO9LvYVl+ZCaKRSMmbU=; b=XvpOSWSrUVauLEZxDSFx6wPyjbRkHh5e7UcU0LbOyHob8TAA9ZMGx6Xu3nHwp7Oaw1 gL6zSfyTF6imAKqI4mTFv3Hgrjho/o5dVcTZe8ZuP271QzFWdJJR+fsjtw9pEDMjYXJM vEMQ49Fw9bjSU/jmSWRRq+aWUGkk+d6RcrB3s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MiCKLpNoPWheDzEBeKxzkSAOyO9LvYVl+ZCaKRSMmbU=; b=NJMJnBMqzu8hPYTQK/T+4DaPDbpIUDxQ+EudASHWSAGsNvUVk/RcsMHq0LnHsVL+Lu olzmXf2ZHXFjV043MeuX5+ar2mqJAOU8363O1dVwfYkRVCU1YyybFXA0sJ2uNgQtGZlT MOuZaBMCAuY7Q9VJeORz95JCfp5bm027EYstN6aPCpbklzfkQk3XBB4IFkhR6BL8iZEs c0IkkwYAk0LdowqfdiCfKKTPuAKkJy5+Y0GLXmmjK1LbeHqofHb1so8NqNDdylWEBcgg 9uxB74s4eqUQwmip67VMLEjEpFNXDLpvLvf3Avgro+aQZ42bi8R2lEF8tJfoJ6Gk/4yv Bacg== X-Gm-Message-State: AOAM533t6ZMzVdf7He8NtMIyCiKrmYLHBNIxWxaGTtrcXLB+pYwWUaJs TCSu1vAzQ5zEtlppWACTZ1pnrQ== X-Google-Smtp-Source: ABdhPJyAuW5EGj5J5gKEF1fhn/HtmJGA9xPBQvcS7yDVS080dlnOXkuA2j35H3aPaeOJ4WREBh5zTA== X-Received: by 2002:ac8:5a51:: with SMTP id o17mr19136680qta.180.1637457029122; Sat, 20 Nov 2021 17:10:29 -0800 (PST) Received: from rfd.leadboat.com ([2600:1702:a20:5750::46]) by smtp.gmail.com with ESMTPSA id f11sm2304663qko.84.2021.11.20.17.10.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Nov 2021 17:10:28 -0800 (PST) Date: Sat, 20 Nov 2021 17:10:26 -0800 From: Noah Misch To: Tom Lane Cc: Andrew Dunstan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests Message-ID: <20211121011026.GB1362012@rfd.leadboat.com> References: <3369543.1637454364@sss.pgh.pa.us> <3369927.1637454743@sss.pgh.pa.us> <20211121003630.GA1362012@rfd.leadboat.com> <3371085.1637455802@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3371085.1637455802@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Nov 20, 2021 at 07:50:02PM -0500, Tom Lane wrote: > Noah Misch writes: > > Yep. wrasse sets PERL to a manually-installed Perl, but PROVE still uses an > > old Perl. I'll fix that somehow. > > A quick workaround is to set PROVE in the animal's config_env, but > I don't think that's ideal, because configure then skips module > presence tests: > > # Check for necessary modules, unless user has specified the "prove" to use; > # in that case it's her responsibility to have a working configuration. > # (prove might be part of a different Perl installation than perl, eg on > # MSys, so the result of AX_PROG_PERL_MODULES could be irrelevant anyway.) The skip would be unnecessary if configure just tested whether $PROVE can run a test requiring the module. We're testing $PERL, but we're actually indifferent to $PERL's Test::More. > What I'm inclined to do is temporarily push `dirname $PERL` onto the front > of PATH while running > > PGAC_PATH_PROGS(PROVE, prove) Adding to PATH, even briefly, is way too brazen. You'd need to be sure that PATH is never searched for anything other than "prove", which is hard to ensure in a shell script. Explicitly testing $(dirname "$PERL")/prove could be okay. It feels inappropriately magical to me, but perhaps it's the right thing. I'd be -1 on a back-patch and -0.7 for HEAD.