Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mobnN-0007yW-TY for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 01:37:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mobnL-0004NB-QA for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 01:37:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mobnL-0004N1-7B for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 01:37:27 +0000 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mobnD-0000nH-Rt for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 01:37:25 +0000 Received: by mail-qv1-xf2e.google.com with SMTP id i13so9836745qvm.1 for ; Sat, 20 Nov 2021 17:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+6lOQCs2ObBsycvEYWYpLPzd/oyJ6dPuQXmCao1yk6Y=; b=bZiGH7k9/BU3zOFwPVV/vRvwqJOq0huVfplElbyawJK0QgUhlxm/NDzaGX3EGk0Y2t C/+CkxiWisTpqxILufmlBGYNHkJYkHouHta3xqfNfTqGr47pemXc/iXKyEU1OjFaBhOm 6dIHP1Bhfbf536I2xdKOh8jcNdpvkDIvuy8f4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+6lOQCs2ObBsycvEYWYpLPzd/oyJ6dPuQXmCao1yk6Y=; b=CuPtm7C5GsWgUDIEP/2YLOAhyTn9Xj9YxMAeHDBR+EgfHVWSWOaQtuI3y2Y1PSCFP4 bOe1h8vk7lu1121Js9I+YQYHZPs8RpHUj66Uw5humO6+m1cOiqwmOSftCz0215W6F1Xr OeuHZav39INjjgkBjasW63GDbMj9WoVH66mWxRGm5IRy8HE97ePhcDd4UmgkWQNpniFR DNEAo7Nvw/wyLKgeXEYmoKWfoSQX1pFp3VnKci8k/Sx0fTcgvK4fzwIkZrGdZIj5XlNe DccFr5IilUgbiuEvZsdineNtBVApMaWcFMMRl3eNyTJRIic+GlI996xERSVkuL5y0C7g ypeg== X-Gm-Message-State: AOAM532LLWyt0MCxj26OfJP6Pc+xVkO09LKEAqM6xe0JBeFj8ehEV+kI N+hoZc+mb00IRr6KhiRp0dm6ZY/+tDwd7g== X-Google-Smtp-Source: ABdhPJxY/25ciUZFJNq6WOo2zXHn1dvTFYZwDKy+V608IS+1nr8FOPAuGx+CNBGLvKGTEyzd0npRtQ== X-Received: by 2002:a0c:eec3:: with SMTP id h3mr87354786qvs.17.1637458638663; Sat, 20 Nov 2021 17:37:18 -0800 (PST) Received: from rfd.leadboat.com ([2600:1702:a20:5750::46]) by smtp.gmail.com with ESMTPSA id y21sm2263019qtw.10.2021.11.20.17.37.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Nov 2021 17:37:18 -0800 (PST) Date: Sat, 20 Nov 2021 17:37:15 -0800 From: Noah Misch To: Tom Lane Cc: Andrew Dunstan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests Message-ID: <20211121013715.GC1362012@rfd.leadboat.com> References: <3369543.1637454364@sss.pgh.pa.us> <3369927.1637454743@sss.pgh.pa.us> <20211121003630.GA1362012@rfd.leadboat.com> <3371085.1637455802@sss.pgh.pa.us> <20211121011026.GB1362012@rfd.leadboat.com> <3386968.1637457734@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3386968.1637457734@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Nov 20, 2021 at 08:22:14PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Sat, Nov 20, 2021 at 07:50:02PM -0500, Tom Lane wrote: > >> What I'm inclined to do is temporarily push `dirname $PERL` onto the front > >> of PATH while running > >> PGAC_PATH_PROGS(PROVE, prove) > > > Adding to PATH, even briefly, is way too brazen. You'd need to be sure that > > PATH is never searched for anything other than "prove", which is hard to > > ensure in a shell script. > > Hmm. I kind of doubt that anyone would be selecting a perl in an > untrustworthy directory --- wouldn't that imply that $blackhat could > overwrite perl itself? Typically, but: sticky bit, NFS ACLs, only-formerly-writable directory, etc. > > I'd be -1 on a back-patch and -0.7 for HEAD. > > I think we need a back-patch of *something*. It's pure luck that wrasse > hasn't shown problems already. I don't want to be rediscovering this > issue a year from now when somebody back-patches some test requiring > subtests. If you want to allow subtests in all branches, $SUBJECT is the thing needing a back-patch. By default, they remain banned in back-patches. Personally, I've just added a check to my script for converting v15 TAP tests to v14 TAP tests: #! /bin/sh # This translates a PostgreSQL 15 TAP test into a PostgreSQL 14 TAP test sed -i ' s/PostgreSQL::Test::Cluster/PostgresNode/g s/PostgreSQL::Test::Utils/TestLib/g s/PostgresNode->new/get_new_node/g ' -- "$@" grep -w subtest -- "$@"