Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpxN9-00085F-AH for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Nov 2021 18:51:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mpxN6-000854-QZ for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Nov 2021 18:51:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpxN5-00084v-QF for pgsql-hackers@lists.postgresql.org; Wed, 24 Nov 2021 18:51:56 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpxMy-0002AD-6d for pgsql-hackers@lists.postgresql.org; Wed, 24 Nov 2021 18:51:55 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3AFA25C0091; Wed, 24 Nov 2021 13:51:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 24 Nov 2021 13:51:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=b0pjQ5tvNnGq8DMTRmbBuLZWX/5GflVEBgdXiz6HpiU=; b=PRDPdW8p xS1uQp1ufNELG24ZjRvamz5iKl70p879Ohk8Z1Lp01vOrm3iARMIjv5wC7jJYWwZ YWZ1NXkunzMOIgd7uECegy6EpbRmgth/z3+p07ajmxyKzmOggDq+g38LocuBhg7m awmqh9GzHmsSHL1JQbmAP0Ud3dewkSQsxlEAKXhDDowuV9CJRP495j90JGSZH7m5 tNsW/FwhrS4QMymFfxDk+3crOY7GCGnpJydLso4ei5YixF2DM/gvGM3rp4i6XS2B iMtXxsA26//ahxKv6LvCUG1Cc7VknmFYMIn66WKlLNiRn0i/tLky+oNniqEcexq4 iVgay4i2Rej1ng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeekgdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeetjeffkeehtddtjeduhfekffehfeevjeehffdthffhheeg feeuveeviedvkedvffenucffohhmrghinhepphhoshhtghhrvghsqhhlrdhorhhgpdhpoh hsthhgrhdrvghspdgvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrd hnohdqihhprdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Nov 2021 13:51:44 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id D1AFC2A07F5; Wed, 24 Nov 2021 15:51:41 -0300 (-03) Date: Wed, 24 Nov 2021 15:51:41 -0300 From: Alvaro Herrera To: Robert Haas Cc: PostgreSQL Hackers Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr. Message-ID: <202111241851.a6jegc3x6ne7@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Nov-24, Robert Haas wrote: > On Wed, Nov 24, 2021 at 11:28 AM Robert Haas wrote: > > xlog.c: Remove global variables ReadRecPtr and EndRecPtr. > > https://git.postgresql.org/pg/commitdiff/d2ddfa681db27a138acb63c8defa8cc6fa588922 > > There is a buildfarm failure on lapwing which looks likely to be > attributable to this commit, but I don't understand what has gone > wrong exactly. The error message that is reported is: No, this is an unrelated problem; Tom reported this yesterday also: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us -- Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/ "La espina, desde que nace, ya pincha" (Proverbio africano)