Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mq39A-0005aB-UZ for pgsql-committers@arkaria.postgresql.org; Thu, 25 Nov 2021 01:01:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mq399-0004yF-OL for pgsql-committers@arkaria.postgresql.org; Thu, 25 Nov 2021 01:01:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mq398-0004y6-27 for pgsql-committers@lists.postgresql.org; Thu, 25 Nov 2021 01:01:55 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mq395-0005Qm-8f for pgsql-committers@lists.postgresql.org; Thu, 25 Nov 2021 01:01:53 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5B16C3200583; Wed, 24 Nov 2021 20:01:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 24 Nov 2021 20:01:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=Y4RYEitjj22H6mxxb/5TdiVMTUt azvKwdpuEffXqogM=; b=Q170fZT8q0ojmILDLSYV4NIg8ZFlfYdIUtEwBoAZEUk aPzwgaP5NOQlVXnZFhl3zohE3JxKimmwPDf64/xWmvIo/NAqJtAOB+pHyYd5nppw Efha5sMdnG9mh7KKGwlMoI/BYlQJR0r6Vo+xW4FjuCJlb9CFPejTFEwVQpOOOc6T BlqycRxK+Yd0FIuiEQ3y5dILyONPuKpyHni+AG3juUa9n6bRExpHfwpUWgm+S130 f11+66moizpP7CIejoY90TWybhwAJ8YiLtdkDFYAChclOiW2t9D4Wv7eueuIF3yk oy9T6IrOthG2eOTBZzI+PyK+2h36081r8cbEXP1dbww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Y4RYEi tjj22H6mxxb/5TdiVMTUtazvKwdpuEffXqogM=; b=hGgjnvWBBsyPu6JdiKbN2V jaHNKdmSiT+fe7+Gfz9Wfeux8BlysDL7us8ofuqoeMNNaZmaYFCZSxPLF7Qvyzus UtJtoPDgaxRuuA9nJXvwXTyRT9+fkmutB4EtJ2SdQ+B8IaOPzfUI/dRo7wblO3MY EsIH+T2NEJFTmp5fmQYFOOARSsa09I88fhXQAD5PwmsWNlu9JZ8Hhjj9S7tJtaIt EkZNRXzOJX/YnS7co03EgbdnkAFcIhI56XKv7Nq+ReexYTihho26rYFiRe6L6OhZ lZh1lp64nihSSDLwRxgCjeCMrSRZpgBEuc/9VSMpOVxfauTXHlsR7RRA8Z/QBUDA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeelgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughrvghs ucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrfgrth htvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeffhfeu ffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Nov 2021 20:01:47 -0500 (EST) Date: Wed, 24 Nov 2021 17:01:45 -0800 From: Andres Freund To: Robert Haas Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr. Message-ID: <20211125010145.fqt4mlkhzyiz4wvw@alap3.anarazel.de> References: <20211124231206.gbadj5bblcljb6d5@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211124231206.gbadj5bblcljb6d5@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2021-11-24 15:12:06 -0800, Andres Freund wrote: > This fails when building with WAL_DEBUG. There's remaining Read/EndRecPtr > references in #ifdef WAL_DEBUG sections... Pushed the obvious fix for that. Somehow thought I'd seen more compile failure than the one WAL_DEBUG...