Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mstW4-0002Cx-Rd for pgsql-committers@arkaria.postgresql.org; Thu, 02 Dec 2021 21:21:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mstW3-00008F-Lp for pgsql-committers@arkaria.postgresql.org; Thu, 02 Dec 2021 21:21:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mstW3-00007j-EJ for pgsql-committers@lists.postgresql.org; Thu, 02 Dec 2021 21:21:19 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mstW0-0001RZ-60 for pgsql-committers@lists.postgresql.org; Thu, 02 Dec 2021 21:21:19 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0208B5C026B; Thu, 2 Dec 2021 16:21:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 02 Dec 2021 16:21:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=dtQZrFK/8qZLrrKHebMJHOiuT+/ yrPgYrE5zccX1AYQ=; b=OUoff6IwNDKogN5fgbhu6B8lZ2ipDgtnMuPk7AtJxwz WZ88ewdIhryb0BcmeUykML4O8uAl1qe7gYrkr7mekOi+RvJm5F3MzoWYhxixDtVg nCDqakFvUGyvI6KuyCfD/T2Up86csddZngNxDwzvWXWkPU2t9xfieYaEGj7ep1lo MsO9wAURs2+bv2H7CmeQucNoKs1p1KCZ1kPCLM8DOIbWscpElXM9pPO0DIfhxCF6 WF9I09sOffZuy+kZdtaPl4Ib89p0aFdqsb1lnVrisfSvFW1+sfUfVVBM85RAauqu DSHauZsvQo3+9Cq9Sa3IRu3p663336bNkDV5KIWn61w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=dtQZrF K/8qZLrrKHebMJHOiuT+/yrPgYrE5zccX1AYQ=; b=CUlqxHOumE4801YrEGkJ4o esh9QdgyLnoz4XpQbX8LMP+2S6xBxO1dBWlbYxTjtzIBCfblqPZ5/q11WA6B/36x j6soBPIKp2i3psJCkyZpIg7+OSCwJnsCQ1wbENara6MSvIPKN5DXgaEtpby4KdpM dhG5xSlsGERWFnCpreC20cmGjHoHxTsJhqt5ip4VH1OYReApL8OeAhMEbcQNdjn6 Jy6uR/I4KifMSh3jN1jMt9h++LqsHuwXxczoO3rbRw207RbOVYVpk8Kl3VjLMe+e c6Y5I5So4INoRT15OT/0Dv7kg9OMgP5P75XSq4g1nOzeOL0s4IqwTK5E1oc1w/MQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrieehgddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpeevhfejveehvddvgfdtueefuefhhfetkefgfedtkefhieeuudefveduffdu gfdvgeenucffohhmrghinheptghirhhruhhsqdgtihdrtghomhenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghrrgii vghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Dec 2021 16:21:13 -0500 (EST) Date: Thu, 2 Dec 2021 13:21:12 -0800 From: Andres Freund To: Daniel Gustafsson Cc: Michael Paquier , Tom Lane , pgsql-committers@lists.postgresql.org, Andrew Dunstan Subject: Re: pgsql: Add TAP tests for contrib/sslinfo Message-ID: <20211202212112.ttklesxps5eqb533@alap3.anarazel.de> References: <1632478.1638305700@sss.pgh.pa.us> <887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se> <1636597.1638308177@sss.pgh.pa.us> <1686601.1638333261@sss.pgh.pa.us> <74D032CB-B5EE-4B39-AFBE-67F835A2CBDF@yesql.se> <50312478-6DB6-4A9A-99BF-2EACFF286149@yesql.se> <20211202195130.e7pprpsx4ell22sp@alap3.anarazel.de> <9ABB6DDC-A3B5-45FB-9EA4-3331079C09CE@yesql.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ABB6DDC-A3B5-45FB-9EA4-3331079C09CE@yesql.se> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2021-12-02 22:07:17 +0100, Daniel Gustafsson wrote: > > On 2 Dec 2021, at 20:51, Andres Freund wrote: > > > > Hi, > > > > On 2021-12-01 20:49:21 +0100, Daniel Gustafsson wrote: > >> Looks like perl2host() was the missing piece, fairywren turned green with > >> commit c3b34a0ff4. > > > > Does that work with MSVC? I rebased my CI patch ontop of this, and it fails on > > windows: > > https://cirrus-ci.com/task/6093088335593472?logs=ssl_test#L5 > > I was under the impression that it did, but it seems that my Appveyor scripts > had a bug which hid that =( Sorry for that. I really want to get the CI stuff merged so stuff like this is easier going forward... FWIW, I have a new colleague working on installing more of the optional dependencies for windows - but we can add those later. > This seems to be another case of Perl being perfectly happy to copy and manage > the files, but Postgres not being able to read them since we'd otherwise die() > a lot sooner. The error message is the same as when the msys directory wasn't > fixed with perl2host: > [04:05:47.204] # got: 'psql: error: connection to server at "127.0.0.1", port 59360 failed: certificate present, but not private key file "C:cirrussrctestssltmp_checktmp_test_AIn7/client.key" > > Looking at other tests, we pass a tempdir() to postgres just fine, so that > clearly works. The one difference here is that the filename is added with > "/client.key", so I have a feeling this is a delimiter issue where Windows > expects a backslash? In src/test/recovery/t/025_stuck_on_old_timeline.pl we do > the following, which IMO would be neat if perl2host (or a similar function) > would do for us: Hm. Isn't the problem that we are not adding enough of the other path delimiters? The /client.key seems fine, the problem is that all the other delimiters were swallowed. Or is that what you mean? I think the difference might be that the most of the other tests do not pass such paths to postgres via postgresql.conf (based on a *very* cursory grep). I assume the guc machinery treats the \ as an escape, and that's why you're seeing c:cirrussrc... instead of c:\cirrus\src\... > my $archivedir_primary = $node_primary->archive_dir; > $archivedir_primary =~ s!\\!/!g if $PostgreSQL::Test::Utils::windows_os; > $node_primary->append_conf( > 'postgresql.conf', qq( > archive_command = '"$perlbin" "$FindBin::RealBin/cp_history_files" "%p" "$archivedir_primary/%f"' > wal_keep_size=128MB > )); > > I'll fix it, or revert if I can't make it work. Sorry for the breakage. And this works because it uses *forward* slashes instad of backward slashes, which then do not get escaped by the guc machinery. Greetings, Andres Freund