Date: Wed, 8 Dec 2021 22:49:28 -0800
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Message-ID: <20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
References: <2e118a11-6936-21ec-6782-e9dbb20972c2@dunslane.net>
 <3657697.1638980149@sss.pgh.pa.us>
 <b179201e-8451-6a5e-e9be-9c755a13be7f@dunslane.net>
 <3660797.1638983124@sss.pgh.pa.us>
 <b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
 <20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
 <3707204.1639016334@sss.pgh.pa.us>
 <20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
 <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
 <YbGYe483803il3X7@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YbGYe483803il3X7@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20211209064928.7f5lp6hxvw2f2j6o%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2021-12-09 14:47:39 +0900, Michael Paquier wrote:
> On Wed, Dec 08, 2021 at 07:08:56PM -0800, Andres Freund wrote:
> > On 2021-12-08 18:46:04 -0800, Andres Freund wrote:
> >> On 2021-12-08 21:18:54 -0500, Tom Lane wrote:
> >> It's not stable, but afaict all the "instability" can be handled by relying on
> >> a system-set environment variable... Referencing it as
> >> $ENV{SYSTEMROOT}/system32/tar.exe ought to work? I'll test that approach via
> >> CI, but of course that won't verify that it works in all kinds of odd
> >> installations.
> > 
> > That worked: https://cirrus-ci.com/task/6302355785252864
> > https://github.com/anarazel/postgres/commit/49cf19f160080353da391f177a7d8c28218023bb
> 
> Well, I am afraid that this is not a completely stable path.  That
> would not work here, for one.

Could you expand on why it doesn't work? As far as I can tell tar is shipped
with windows these days, and %SYSTEMROOT%/system32/tar.exe should point to
that tar?


Greetings,

Andres Freund