Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myJCX-0003Jf-97 for pgsql-committers@arkaria.postgresql.org; Fri, 17 Dec 2021 19:47:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1myJCV-0007My-Vw for pgsql-committers@arkaria.postgresql.org; Fri, 17 Dec 2021 19:47:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myJCV-0007Mo-P0 for pgsql-committers@lists.postgresql.org; Fri, 17 Dec 2021 19:47:31 +0000 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1myJCP-0001mm-6W for pgsql-committers@lists.postgresql.org; Fri, 17 Dec 2021 19:47:30 +0000 Received: by mail-qv1-xf2e.google.com with SMTP id h5so1669106qvh.8 for ; Fri, 17 Dec 2021 11:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Mqg5K+KrVVCaDf4LPrTG4PFU9xLIJbMsAm3u0cAPUSo=; b=P4ndod/j3hEiDybtGHuu3eyfvlgvR/fwj/5uJZn+SDZF6raPiCZucqhywc+yPpfram yl+5vP40GiajpUfnMibOhkUI0f9KjOquGjVdnu+o0pWLAS/DAtWAif4Pm6mSCvgZvXkH C82rsWZliBRtKQrraOB3tc4gvRXawNw8DjV8w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Mqg5K+KrVVCaDf4LPrTG4PFU9xLIJbMsAm3u0cAPUSo=; b=JPVMHMbTMzwPsJwc57+kcfCGZUqUpiLejyFmLMdzAhs3EL0fVfoKf9pQJFQoUzfwsi 5f0TS19qj3xYWQBajbKyHAYATzgXQb5fqho7TbesTW1onkbvyWVust9PHLSWkcrggSCV g1EIHAceS0Ei2ErUXyo5XLmu5LrDePjoJ/3gb7vLTmxyYYgSfkUSySMUjFvhnD3xYB5L nuVOEnd4SIeDzGKvVSc+dbKzc0ISX9s6xMcZ+qBMQXD2d8osBMcLWUOL4h9rHTU61WHJ Gdqo1jfKJOdciUrIeBdcSe6SEUhk4rG2A65z6/1VAwA5S4/ZJQR0/w01TnhFx9P/A4s1 3GFw== X-Gm-Message-State: AOAM5325nUpvUUR6enoQaIUbuRZMnaZ/0lRkRS2eO06SUE8XNclD0KC+ G8RKJNrBO88r+TB5gfuBY08IAeo0SgpxZA== X-Google-Smtp-Source: ABdhPJzy8fRIEn/eot8S6KAyv0f7RfU7oevuzV7LAJRnkisDXmxCFr11KvnuYuf/GVfcov4dJD/Sbg== X-Received: by 2002:a05:6214:29c4:: with SMTP id gh4mr3859893qvb.118.1639770444391; Fri, 17 Dec 2021 11:47:24 -0800 (PST) Received: from rfd.leadboat.com ([2600:1702:a20:5750::46]) by smtp.gmail.com with ESMTPSA id r4sm7326495qtu.21.2021.12.17.11.47.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Dec 2021 11:47:23 -0800 (PST) Date: Fri, 17 Dec 2021 11:47:20 -0800 From: Noah Misch To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas Message-ID: <20211217194720.GB2529654@rfd.leadboat.com> References: <1363170.1639763559@sss.pgh.pa.us> <20211217182518.GA2529654@rfd.leadboat.com> <1368839.1639766460@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368839.1639766460@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Dec 17, 2021 at 01:41:00PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Fri, Dec 17, 2021 at 12:52:39PM -0500, Tom Lane wrote: > >> It's sort of annoying to fire up a psql+backend > >> for just one command, but perhaps there's other stuff that could be > >> put there too. > > > Yes. The src/test/regress suite would be in a better place if one could run > > most test files via a schedule containing only two files, the setup file and > > the file of interest. Adding things like the "CREATE TABLE tenk1" to the > > setup file would help that. > > If we're thinking of a generalized setup file, putting it after the > tablespace test feels pretty weird. What was your motivation for > doing this at the end of tablespace.source rather than the start? I did it that way so a bit of the "make check" suite would exercise the standard user experience. That's a minor concern, so putting the setup file before the tablespace file is fine. Various contrib and TAP suites will still test the standard user experience. > It doesn't look like that test in itself had any interesting > dependencies on public not being writable. Right.