Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9YvS-0003mI-5h for pgsql-committers@arkaria.postgresql.org; Mon, 17 Jan 2022 20:48:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n9YvQ-0002zN-Av for pgsql-committers@arkaria.postgresql.org; Mon, 17 Jan 2022 20:48:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9YvQ-0002yc-3X for pgsql-committers@lists.postgresql.org; Mon, 17 Jan 2022 20:48:24 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9YvJ-0002lE-DN for pgsql-committers@lists.postgresql.org; Mon, 17 Jan 2022 20:48:23 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BC89F5C011B; Mon, 17 Jan 2022 15:48:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 17 Jan 2022 15:48:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=0bvhPtX0UHFA7VnFfaYZRt1sRaN xzgT+wDlnhb5+PT0=; b=dm2C0s1HIx71EA6ESRMHd60j+c9gWRIpzxpIBv2cWXs WaMPyK9QbKCaBPMkCexOjhuE6Rayjt0VU2DohrVK9RaGvmHV5vKGzTJkvUx0DzqU Zgn8wjYdH9tA75TwfC9ofuFsiWbfrzZkFNj15SpIa1pDQqS6N30YZAjRVC82XYLZ GJdXdPAGDg2oXV8qYhj7jEjykoZ+bLMNgiS231u/5lqiAu54WfS8V43vWPNfAIEj /VjAN5aTaxHCiLKfLxxAfVFcx9/PdCSIqIJIq/kbAFjQOAecMdl/ocFYpI6zX+Ii A+70cSxYtAwbWuxLNj3i2P7r3AR3C6Lgx9tI9eSX4zw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0bvhPt X0UHFA7VnFfaYZRt1sRaNxzgT+wDlnhb5+PT0=; b=NhdDBIchyGyixirsaBZRph Nvr9Nq2rjJ8u3sHTDLLcEYfzBl7isjO+k2jVPLrfYXWBlsoQIhLOAmRodswgu2g6 URIJd0reIKqUypsVPOGN+FI4ozjWPyENeLO8w/GHe/wLLg24Fh2iRB/iUi4Uu9t0 joO3IIubJ2v9O4EoBDS7Bhd0IHLniqz4QuUaIM+zMkCCFg10WAOHmeDT5ogrAaYb bG1Vy+71ozDaw57KfhUPUBMvvONwRLzhDLGa4Q4xIkxIMIxyLHK/cxQAzkFc8iC7 w0/TiidBeKbrifxhVhMwevk+7mlA3qR4/18VRuj/p69edECro30hzX9FLuLwzZaQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddugddugedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedvteelgfeuheeftdfhheeuhffhveetudejleffhedtheeukeeiheekudeu tdejfeenucffohhmrghinheptghirhhruhhsqdgtihdrtghomhdpphgvrhhlrdhorhhgne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghnughr vghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Jan 2022 15:48:15 -0500 (EST) Date: Mon, 17 Jan 2022 12:48:14 -0800 From: Andres Freund To: Thomas Munro Cc: Michael Paquier , Thomas Munro , pgsql-committers Subject: Re: pgsql: Test replay of regression tests, attempt II. Message-ID: <20220117204814.5w2kjxclodxjclwn@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-01-18 07:47:48 +1300, Thomas Munro wrote: > > No idea what's going on here, but I guess that we'd better show up the > > contents of regression.diffs in the TAP logs if it exists. > > Hmm. Yeah. It already is in the regress_log_*, but I agree, it'd be good to add it to the normal output in the failure case. https://api.cirrus-ci.com/v1/artifact/task/6460573058596864/tap/src/test/recovery/tmp_check/log/regress_log_027_stream_regress I think system_or_bail() might be the wrong tool here. If I understand Test::More's BAIL_OUT() correctly [1], it'll prevent other tests from running as well. Which doesn't seem quite right for a failure like this? Kinda seems like nearly all of our uses of system_or_bail() are bad? Greetings, Andres Freund [1]: https://perldoc.perl.org/Test::More#Test-control "Indicates to the harness that things are going so badly all testing should terminate. This includes the running of any additional test scripts."