Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9dIH-0006xz-Oc for pgsql-committers@arkaria.postgresql.org; Tue, 18 Jan 2022 01:28:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n9dIG-00023U-Hi for pgsql-committers@arkaria.postgresql.org; Tue, 18 Jan 2022 01:28:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9dIF-00023I-I3 for pgsql-committers@lists.postgresql.org; Tue, 18 Jan 2022 01:28:16 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9dIC-0000dj-Gi for pgsql-committers@lists.postgresql.org; Tue, 18 Jan 2022 01:28:15 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D4CF45C0103; Mon, 17 Jan 2022 20:28:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 17 Jan 2022 20:28:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=7vRQ/kOVj83rix/4U58Eh7Q3FZF qCw6NrjxjovZWS1I=; b=Vu+ndHZP0zqQVLfpNJol3atfMeMO6IzeC7uHsH0hTKy OhjMgaR6wQ1spWoxzLeTF4g+yZgykeBdNQHdKKAHEz988KPYyWaPlatdPJrpIUcW 5VLYfrk9JW5nToVSIiXrb74BZdZI2YsEvFERzxZcd5x7Db27YG1kFGAlrk6xeMtS 1ZENdUKI6SagBfUdCFlhaCVXIXsTRWb1sy7VHTsEeuyd6aJwbJRZBgzZ4pUnWaqP uXlECS9x17qmc4X5mbbICVOtux9cMsDiWtHyvM8S+zoikFVB7oWmvBrO5wnz4nXE msRsajW0ZHL9HsInZSk0KvJ8Zy1lf3KjlMfBreIgr5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7vRQ/k OVj83rix/4U58Eh7Q3FZFqCw6NrjxjovZWS1I=; b=B3qmAv1aG/ped4+GtLiRAR VHrJ9g2K8RWKV6Q+Du80oDtRKBJ+bhH8vhjXH5MASUX6CQC6gNFexpRVZfmR5dab PoITCQqYxAfe82Mn7Obq0bAkztFZgoIaUcHDo57zkEhnWKjPOos8/SkgVzJ77yZM n5uicBYgnHVDk+ZsU8EbAeSR1EUeZi8Yw3vYkrrUrDhWG5fAvrKEABau1Em6wV+/ loOblhsCksdJg0rYu2n23nvq63mgOxPJXXz2FDKhXLm7muGvXJbS/eMMckWCPoWQ D4+mSkRqjjfuv6AVCeyb2Yb3jhXBLLmy+VovlTJcKWMkklQuDvyWdE7JHfdC6nGg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughrvghs ucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrfgrth htvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeffhfeu ffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Jan 2022 20:28:09 -0500 (EST) Date: Mon, 17 Jan 2022 17:28:08 -0800 From: Andres Freund To: Michael Paquier Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: tests: Consistently use pg_basebackup -cfast --no-sync to accele Message-ID: <20220118012808.dc4jkvbu5fqnmflr@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-01-18 10:18:36 +0900, Michael Paquier wrote: > On Mon, Jan 17, 2022 at 11:48:02PM +0000, Andres Freund wrote: > > tests: Consistently use pg_basebackup -cfast --no-sync to accelerate tests. > > > > Most tests invoking pg_basebackup themselves did not yet use -cfast, which > > makes pg_basebackup take considerably longer. The only reason this didn't > > cause the tests to take many minutes is that spread checkpoints only throttle > > when writing out a buffer and there aren't that many dirty buffers in the > > tests... > > Are you planning to back-patch any of this? It seems to me that it > would not hurt, and making the tests faster on back-branches saves > time when working on those branches. I hadn't planned to do so. Back-branch tests don't run even close to as often and there's enough difference across the branches that it's a bit of per-branch work to adjust. To me this mostly seems helpful to reduce test times on buildfarm critters / CI and branches we constantly run the tests for. Greetings, Andres Freund