Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nD8qH-0007kM-Ex for pgsql-committers@arkaria.postgresql.org; Thu, 27 Jan 2022 17:45:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nD8qG-00029o-BK for pgsql-committers@arkaria.postgresql.org; Thu, 27 Jan 2022 17:45:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nD8qG-00029f-0r for pgsql-committers@lists.postgresql.org; Thu, 27 Jan 2022 17:45:52 +0000 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nD8qC-0002AA-Vm for pgsql-committers@lists.postgresql.org; Thu, 27 Jan 2022 17:45:51 +0000 Received: by mail-io1-xd29.google.com with SMTP id q204so4491790iod.8 for ; Thu, 27 Jan 2022 09:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RaHmkosox21yRFUbAK03Orv7YeM3IuqfYTk5CQxDXyo=; b=2B3sP16FJi5jk6cstfWkpOZ3qaG1upF45pYvRC1SsVcsyr6YW+uHXflN6UkaovtGzI 5snx/rnxR0AbT/Xa2M4E3bhzrURNp071Jl6bsFHNZZZ1jaBGNrYrum2bfEadBwA1ExJp kDutFCW+CLfMShsAcdKkUT4WiCIjKr79LxbXK92NCKtdNGA8ZZhIwaBHNZ544KExPore i4lYcx90R7GliAUwbA+afljgVRtTJEZdocn4Br20mThf4ewzAPRdsFIhoeCvIsfp1D5k oFW+2rqmjqjOprMFd1rXz99uAOomjKcKgpuEUzHcy0ivI3ZZ/WAozCPgAphUpeX87hNv +IwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RaHmkosox21yRFUbAK03Orv7YeM3IuqfYTk5CQxDXyo=; b=LjzO4enyFQC2kG1kXusMdSEhuVnVcxNfo/ijrcGsPQ3RheYzS0xRpeOKqqYWY3MKRW +3P3poFCTxIeRz+eoVSkUKLggZULHBRGwMm2fHC5WLxlX8RgLujvph3VkDQokFtsxA4T uJipl5FcJB1FO8/nleAKxU+mdy4Rjq7qu3PQD9ZOeLhsEIFPKc1qREKCKhBci8URRoWQ cwZJ+5xzRc4r0UrSMnkdsYOVbpOMS3q2zv4zMNS+hpVBFsPw7hmng5m+myivYoDx7Yt5 eosiEuUwUPGhgDBp9azKBAygH6mXob2aOtzs/j5/21krjwFqWLMxc8bCU5ZetnYlOqt6 GWYw== X-Gm-Message-State: AOAM531uV9Plyz+VWwwSQp0FMPbGz6ju+L/1i0kht+Yp0MqULCFuZS5j YoLX7go7GYQ9qwVWj5FJxlIoHHkWB92KIg== X-Google-Smtp-Source: ABdhPJwjkgxKQaZNwd2ccoh/FwVg5okkrMNQ+36FES49a9opePGEHWddkjW4M2kDgjhXTvVZ98onqw== X-Received: by 2002:a05:6602:1347:: with SMTP id i7mr2684748iov.141.1643305546357; Thu, 27 Jan 2022 09:45:46 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id r64sm8769277iod.25.2022.01.27.09.45.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jan 2022 09:45:46 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 3913580454D; Thu, 27 Jan 2022 11:45:45 -0600 (CST) Date: Thu, 27 Jan 2022 11:45:45 -0600 From: Justin Pryzby To: Robert Haas Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs. Message-ID: <20220127174545.GV23027@telsasoft.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jan 27, 2022 at 04:15:45PM +0000, Robert Haas wrote: > pg_basebackup: Fix a couple of recently-introduced bugs. > > The server expects the compression level to be between 1 and 9, but > Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value > to the server. If I'm not wrong, this is causing failures on cfbot. https://cirrus-ci.com/task/6312181619752960?logs=build#L2056 [17:24:48.348] c:\cirrus\src\backend\replication\basebackup_gzip.c(90): warning C4715: 'bbsink_gzip_new': not all control paths return a value [c:\cirrus\postgres.vcxproj] [17:24:48.348] c:\cirrus\src\bin\pg_basebackup\pg_basebackup.c(1922,67): error C2065: 'Z_DEFAULT_COMPRESSION': undeclared identifier [c:\cirrus\pg_basebackup.vcxproj] The warning seems to be what's fixed by David's patch here. https://www.postgresql.org/message-id/CA%2BTgmobSeRFM84pwa5HfZCGRx%3DQ-iFfPFZfq-4%3Dt1p04yxg_Og%40mail.gmail.com -- Justin