Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDALa-0002zn-Ai for pgsql-committers@arkaria.postgresql.org; Thu, 27 Jan 2022 19:22:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nDALZ-0007U5-6q for pgsql-committers@arkaria.postgresql.org; Thu, 27 Jan 2022 19:22:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDALY-0007Tv-Tc for pgsql-committers@lists.postgresql.org; Thu, 27 Jan 2022 19:22:17 +0000 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nDALV-00035P-QE for pgsql-committers@lists.postgresql.org; Thu, 27 Jan 2022 19:22:16 +0000 Received: by mail-io1-xd31.google.com with SMTP id i62so4906083ioa.1 for ; Thu, 27 Jan 2022 11:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7DyGfuUM2NM/O+M/Z+ySO7uAhxmHD5NUAbGSXuEFvP0=; b=Xk3obPGXrzsPzLtYevl2riXjJYvN9kfLgcDdtZjvSKoNDBjfnPrTZPbhBSegVqAPxK BspHB0pvBQ5gX0oar0giHv/c9sTyUzdRaIax/FR+pUDsPCmNLQ+KJdmvrcZEG2WjGxtk XIr/oveSMmHB15PJJdiWGskQps/RGigHQKmIQKllw6BK8Bw5ACBDzOM1TJ3xvu3cErcR Z3m8FZdSMMge+aJe6iG4DQXxAJ/ebkmJ6WBZikbJEr/3KoPWQph8vy9X+KIdRCg/eEr3 N/P3vmxZCSD8/yeNUJsWvEBXdXMtwmm7sMQw7b0Rr6Gkps8zqsWqHKkrWT8ihd/ite/6 JBxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7DyGfuUM2NM/O+M/Z+ySO7uAhxmHD5NUAbGSXuEFvP0=; b=WqsBw+Q0qWJvafXW6mDxeke7/6VDvhotj68C3DeKZfuV5NYt6tmvFdKFurdLxefPYV G+ExzJSM5gsgXdW5eJGddhot5kNp/jGSsQWR9zzB1/EkB8TwyQWhiOoRflAKTiNt+p8M 8fXh6ftbet/nx7Sk+8VBRHug01ZoJzERq1osSKbRFWIDq6+eRQXiVv3tcsfHyarbMUmE buYp9UQc4TQn65pvltyDJCjJPSrNJyEBzVE8s8HcRNylFK3Wsnh21U9GBGVe//pWJmfr plyafeBpLLaq73Y1iHTNE3/4RUiQOf5Ybv4SjE+OvI9XOJn4KUybdw6oxkxXFSeReWA+ 6stA== X-Gm-Message-State: AOAM5317eT7T/Ro6Jr89waHIQNG9sXfZocCVRsrWEkJX4j6QEUtAh2x/ VnmEXwpoDFvFYPEavjPP3FrQZg== X-Google-Smtp-Source: ABdhPJzjoxZ/5sogdRzxzGZqtg5ICx8arER6MmMfNgskXMU7IBOV2qzD4XhjC1arqeqCjWrmO1nCqA== X-Received: by 2002:a6b:5819:: with SMTP id m25mr2983710iob.37.1643311332037; Thu, 27 Jan 2022 11:22:12 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id n23sm6704054ioo.55.2022.01.27.11.22.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jan 2022 11:22:11 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id D3614800CEB; Thu, 27 Jan 2022 13:22:10 -0600 (CST) Date: Thu, 27 Jan 2022 13:22:10 -0600 From: Justin Pryzby To: Robert Haas Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs. Message-ID: <20220127192210.GW23027@telsasoft.com> References: <20220127174545.GV23027@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jan 27, 2022 at 02:19:30PM -0500, Robert Haas wrote: > On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby wrote: > > If I'm not wrong, this is causing failures on cfbot. > > https://cirrus-ci.com/task/6312181619752960?logs=build#L2056 > > > > [17:24:48.348] c:\cirrus\src\backend\replication\basebackup_gzip.c(90): warning C4715: 'bbsink_gzip_new': not all control paths return a value [c:\cirrus\postgres.vcxproj] > > [17:24:48.348] c:\cirrus\src\bin\pg_basebackup\pg_basebackup.c(1922,67): error C2065: 'Z_DEFAULT_COMPRESSION': undeclared identifier [c:\cirrus\pg_basebackup.vcxproj] > > > > The warning seems to be what's fixed by David's patch here. > > https://www.postgresql.org/message-id/CA%2BTgmobSeRFM84pwa5HfZCGRx%3DQ-iFfPFZfq-4%3Dt1p04yxg_Og%40mail.gmail.com > > I can commit that patch (though so could David) but I don't understand > why you think it's connected to this commit particularly. The C2065: is connected to this commit, right ? I included the warning since it's 1 line away and evidences that the warning is easily visible , and not due to some obscure combination of windows settings. -- Justin