Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nES9m-0003T0-3Y for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 08:35:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nES9k-0007HI-UN for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 08:35:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nES9k-0007H7-LG for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 08:35:24 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nES9h-00036h-0M for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 08:35:24 +0000 Received: by mail-pg1-x536.google.com with SMTP id j10so11592557pgc.6 for ; Mon, 31 Jan 2022 00:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=s+iJBL9mJ3yHgBuzwRZUxpKK3jDYs/aCiOBhoeEFpVw=; b=Nw9i8wYQdkDr2NqjQJzTQOyF0GxcSI2g8KtuTBMUb1NEGvv8Fn8UYOuk/3V17bmPSU Ei6EE5KvePSVDoidKv4782WZpDPTCUuncvkepNg5RA2Xgd5CR19DcAIYKYHupeDP0JY8 el2QoylBPfZ6Qw0f0J/SZXHLOOwU5Mo5NPuVasRR7yLwLktQCb+w3iue1Wx38eOyIEOi UvpHrE23OpHPPJV+p495BtK3QMpfN+HBiYJ4yib2kemmJKAP2AMJQbn+AO0lFpLIZIhF FUyOhHjEivGLGivvQDCz7jmp9B371BYTjYHOKO+T10rQkV1zDB4lkF8BzELkQUvCZbAL 7pUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=s+iJBL9mJ3yHgBuzwRZUxpKK3jDYs/aCiOBhoeEFpVw=; b=1KeSGh0RV0yl2RsTyPdU6CUAuiq9/U/7p88+m8T41Xw5HJdERuPfFbS7f2t9/BqkBv ZWHxWVo5Fb5sf05Mr7VJ9F+FRF/KEmbo7LfhtjOpwQmJSnAO0vEncu1f6MIEwhbSHMYA j9FwPk5oiGE7x/iJfn3oDaNM/B8yAEyKuOe6iRueNCFMZRwFK/mtoXp27v+MBZmXhA7J T8sm+p99fCwgtzZ3+Pr2K1rpJ9VJm8HoVhAWp/8KJCa0mre0c9tGlyscvkBKoKuNcE3F DvkIeh34PAv3JlQ+2TJPo8BVEWPyoL/xR9CxbH22yBjWBAJySeFEdnl0/oEMnAMOwPKA /AqA== X-Gm-Message-State: AOAM530pR81Kco6gYEcezDLArnfW2SQAjReueBAGvcPZWqPzjQAb19tP qWMYqGxcMu13rPv+RE+uqf0= X-Google-Smtp-Source: ABdhPJyUkHnYcmHkoCnlrhRl21CNhAFIGQ2nWTWFIFgc0ZEmKFBEks6JptXdMYWOZQfTCgueQ2UvKw== X-Received: by 2002:a62:cf81:: with SMTP id b123mr19617023pfg.47.1643618118897; Mon, 31 Jan 2022 00:35:18 -0800 (PST) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id m14sm6782680pfc.170.2022.01.31.00.35.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 31 Jan 2022 00:35:18 -0800 (PST) Date: Mon, 31 Jan 2022 17:35:16 +0900 (JST) Message-Id: <20220131.173516.954037459158462050.horikyota.ntt@gmail.com> To: andres@anarazel.de Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai From: Kyotaro Horiguchi In-Reply-To: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> References: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Sun, 30 Jan 2022 17:35:48 -0800, Andres Freund = wrote in = > Hi, > = > On 2022-01-31 00:44:39 +0000, Andres Freund wrote: > > plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failur= e. > > = > > For older versions we need our own copy of perl's setlocale(), beca= use it was > > not exposed (why we need the setlocale in the first place is explai= ned in > > plperl_init_interp) . The copy stopped working in 5.28, as some of = the used > > macros are not public anymore. But Perl_setlocale is available in = 5.28, so > > use that. > > = > > Author: Victor Wagner > > Reviewed-By: Dagfinn Ilmari Manns=E5ker > > Discussion: https://postgr.es/m/20200501134711.08750c5f@antares.wag= ner.home > > Backpatch: all versions > > = > > Branch > > ------ > > REL_14_STABLE > = > I see this broke on everywhere but master. Looking. Anyways, I can build on windows with this (even only on master). Thanks for the work! regards. -- = Kyotaro Horiguchi NTT Open Source Software Center