Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nELbn-00066E-Ri for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 01:35:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nELbm-0006Hv-Mz for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 01:35:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nELbm-0006Hm-GJ for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 01:35:54 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nELbj-0008AE-LR for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 01:35:53 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8FF675C00F4 for ; Sun, 30 Jan 2022 20:35:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 30 Jan 2022 20:35:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=xpTOVuDaj4ZAi3 iUZS0cgc5E+CC23bopR8LY4mfYfxo=; b=zPDv8anzzHtrpeqgpDWc53dzg/qSAl 5LlNfUM7N5RUy+oMoy/9NJVnEykBZ1GdcFm7iwrF+xUZ8Yo8ivySdwI9YcKbS7cE WMUCtBVpe1fH8EkLZVwbq5jDGX3oc/wb+w00zAW5UgYmV/Vz5lrnyYmKJnQwdOWh meIVvBAD38FEtQbBJNcqQNsOVjwbNWPhVWycrJcKDISvX17x0i+OalvqLFUkc0jz ntg5MJp+r0nUkwN0S9oCkKMmoN2rrhYYdttmccUDDIg5KwbNAhnrPZRyweeoTFuK BGFqMjA3Wqv85gPmxalhCwP/XGNb+vyCzTMGtNApx/SM/VeVzyPVRuEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=xpTOVuDaj4ZAi3iUZS0cgc5E+CC23bopR8LY4mfYfxo=; b=XxLVu3zr FF/Q5xabahWzICq7c6N5zw5ZrT53NgEo7TXiIat2BmAY0T1MtZhjIvDKeVlf1Sce XcFxPxHsv4AVvZCUQu39vJlSWXppyffAvrS5XT0FMzzkfDQEDwwO3ghkCWczsvke iCbJcESt/I9Fapm1HRD3GLdKRuY8NjX+mrtUe0X0uESTs+536DnhFnzejZ7k//eE ojw+vz6BT73Sl3C6IBGZMMeLg8r3TsUVaCm3VIrstLy1ClJDdVVCK+ZT47QzIOFE 9JGwSKL8uHwypp7Wou6AsC2BzVcacwq92Anb9GqyMdBCHv6mf1z3WBfIAbO+0C+5 tqExFx4SjPTiYw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgedtgdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtugfgjgesthekre dttddtudenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghn rghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhepheeihfdvvefhiefgtdegvdekle eiueejgfetheejuddvffefuefguedtleekleeinecuffhomhgrihhnpehpohhsthhgrhdr vghsnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 30 Jan 2022 20:35:49 -0500 (EST) Date: Sun, 30 Jan 2022 17:35:48 -0800 From: Andres Freund To: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai Message-ID: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-01-31 00:44:39 +0000, Andres Freund wrote: > plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. > > For older versions we need our own copy of perl's setlocale(), because it was > not exposed (why we need the setlocale in the first place is explained in > plperl_init_interp) . The copy stopped working in 5.28, as some of the used > macros are not public anymore. But Perl_setlocale is available in 5.28, so > use that. > > Author: Victor Wagner > Reviewed-By: Dagfinn Ilmari Mannsåker > Discussion: https://postgr.es/m/20200501134711.08750c5f@antares.wagner.home > Backpatch: all versions > > Branch > ------ > REL_14_STABLE I see this broke on everywhere but master. Looking. Greetings, Andres Freund