Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nELr0-0006qw-Dv for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 01:51:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nELqz-00031R-BL for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 01:51:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nELqx-00031G-BR for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 01:51:37 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nELqu-0008Ko-KW for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 01:51:34 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AB3E35C00B1; Sun, 30 Jan 2022 20:51:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 30 Jan 2022 20:51:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=ITaCxcAROQbvVc 1J0w0T4O1I2s2hMLcQLd4vWWJ7+f4=; b=w3KIl8DukVHmWvl/hvBWTio75+ts6B r3q3rm39KBSUUKb9hPFR8dBEgIftVO/sHkDDRn97gi9k4JUkkrrNoHkm8g/W3GdH bA89xSNdoQBmiQZW6s71mUk0lMbxRne4qrzAXHnc7zK2oZGdHeO9tT8p9U3/Zxjt dZbgFQBsEtiyGqfN9ZssoVjhfEMWCYLwXBnl2m0GV1ot80F6HX9bDRXjEvqsUbUv 6h20ArSoQIT5qYyLZXroX9aobMa9enIfJx/yNWgLP86V4xUDnSof+U1NQP7fVxPg CeqwivRm5KDY7h8MayxT6CV/u2Hu9gsgJ0DjMw7B71MNi92kKd8LCFLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ITaCxcAROQbvVc1J0w0T4O1I2s2hMLcQLd4vWWJ7+ f4=; b=RTVxIESI7RAxV3cydAsfE+ux63T6F2picYqMM3/PR9n86uZNwTL3jaAvE WM6+hKfYtfquh1ZxLiexEQrKDo+FBVs5UhSRwPCE+tt0ffrCXaOfgtnmrD71qc5x dMX8Mg0C+dvkZucxtburXQoEJdzEs8yPnchGf7ozUvlnwDC2MfOiNCCVRbwRVZDj MlxVFrbB8xMrNXqCe0Gh8qdH3tBKGn3dmX5lnppXYau8G24qPM83FpvGLl0l0xDm Y+NFXtkT0Lcius4Wljaoek3UApltvg8/l625RXysCLE7udmiZnFd/qfj539FOYGC f7vSFWwIEzWK2vqGA3I12C7D6qJrQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgedtgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtkeertddttddunecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpeehiefhvdevhfeigfdtgedvkeelieeujefgteehjeduvdfffeeugfeutdel keelieenucffohhmrghinhepphhoshhtghhrrdgvshenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghrrgiivghlrdgu vg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Jan 2022 20:51:31 -0500 (EST) Date: Sun, 30 Jan 2022 17:51:30 -0800 From: Andres Freund To: pgsql-committers@lists.postgresql.org Cc: Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai Message-ID: <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> References: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-01-30 17:35:48 -0800, Andres Freund wrote: > I see this broke on everywhere but master. Looking. Ugh. It's that we didn't backport pport.h. commit 05798c9f7f08908bdd06c82d934da67535b72005 Author: Tom Lane Date: 2021-10-07 13:59:43 -0400 plperl: update ppport.h to Perl 5.34.0. Also apply the changes suggested by running perl ppport.h --compat-version=5.8.0 And remove some no-longer-required NEED_foo declarations. Dagfinn Ilmari Mannsåker Discussion: https://postgr.es/m/87y278s6iq.fsf@wibble.ilmari.org I didn't see that locally (linux) on the backbranches earlier because I had the #if defined(WIN32) && PERL_VERSION_LT(5, 28, 0) split over two ifdefs. And only merged it in a last bit of cleanup :( Unless somebody comes up with a better idea quickly I'm going use a plain PERL_VERSION check in the backbranches. Might also be a good idea to backpatch the above commit, but that requires more discussion than I want to leave the buildfarm red for. Greetings, Andres Freund