Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEM8S-0007c5-5c for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 02:09:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nEM8R-0004Pt-3D for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 02:09:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEM8Q-0004Pk-SN for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 02:09:38 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEM8O-0008Sc-Mp for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 02:09:37 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5260A5C00FE; Sun, 30 Jan 2022 21:09:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 30 Jan 2022 21:09:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=cN/MEgEl5Hyl3097yvtyq93q145k4VR3iQLI2l v+G+M=; b=ldXtSIFdI8PGoTWx1+GKdB1ZbgAr95rG/Kt1NZznOj3TciHTZnxERK xp6Wdw7OA3xWNMBCXtOXt/neUFJ/iwh+/lhP5Cq+TGpjOtomjDcOSrD4tL8lXl5c nZCq9GOOcpnBkojnlSMe1lo2MbCrfwc606UfqoSJCnQn+IaMpsAaoK43qpnC5Rkr LrGGCQJARM0rtfJkHtMQw5sxJSH1pBFOeoIZrQJWYjjkQGzcef9ebgod+5NXa6w3 wexkvS3tg8gAP7/iAlQGIJVK3mibK8Pa+h3JANgWV7sS+4YWNuWd3kPSWXGNbMd+ /rFvX9GU251b9BHmPEfS4vczxmgHwy9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cN/MEgEl5Hyl3097y vtyq93q145k4VR3iQLI2lv+G+M=; b=m91N+h46ex4KkfKCFLX0jMMJrGURhTKvQ UH5xixjFOlm31lDmiK0MXboJBvzz8gXxkorFajne/b4P60UG3sXnzXgxN/45a/hp Y9YCKC1mDm9rXBhrwxeit+Ie0gLeOapj1MwRglMGzv7TNhk8HydcqCmGNpL8bNel WEK/0dO/aGOgOrunDmxt8j60hBOjwn0yugQCu6USB7XkIaRbytu9aQWxSnaC1kN6 Qz7MMytqHQzMaFYTn9IWc4rxitYphCF7ROaMGitiVglAm9tCZxIRb9BnU1/M8ia9 UHUUnSJgBWmsYevV9xy6ITwocKyl3stHNtbKXKefkq7xknEwXgo3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgedtgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughrvghs ucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrfgrth htvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeffhfeu ffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Jan 2022 21:09:35 -0500 (EST) Date: Sun, 30 Jan 2022 18:09:34 -0800 From: Andres Freund To: Tom Lane Cc: pgsql-committers@lists.postgresql.org, Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai Message-ID: <20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de> References: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> <535668.1643594467@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <535668.1643594467@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-01-30 21:01:07 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2022-01-30 17:35:48 -0800, Andres Freund wrote: > >> I see this broke on everywhere but master. Looking. > > > Ugh. It's that we didn't backport pport.h. > > Ooops. I've pushed the quick fix of just using PERL_VERSION for now. That's, as Ilmari noted, not necessarily future safe, but for now it'll work. > > Unless somebody comes up with a better idea quickly I'm going use a plain > > PERL_VERSION check in the backbranches. Might also be a good idea to backpatch > > the above commit, but that requires more discussion than I want to leave the > > buildfarm red for. > > I think we oughta backport. We didn't do so at the time because > we thought it was mostly cosmetic/future-proofing, but evidently > the future is now. > > I can look into that tomorrow or so. Cool. I can either do a revert of the set of commits just now afterwards, or you can fold that into the backpatch... Greetings, Andres Freund