Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFgye-0007Ge-4M for pgsql-committers@arkaria.postgresql.org; Thu, 03 Feb 2022 18:37:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nFgyc-000503-Ca for pgsql-committers@arkaria.postgresql.org; Thu, 03 Feb 2022 18:37:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFgyc-0004zu-37 for pgsql-committers@lists.postgresql.org; Thu, 03 Feb 2022 18:37:02 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFgyZ-00086o-Fo for pgsql-committers@lists.postgresql.org; Thu, 03 Feb 2022 18:37:00 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id F07A9320233E; Thu, 3 Feb 2022 13:36:57 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 03 Feb 2022 13:36:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=HC7QihwpxyeOWb y25T44pPUvZBNZ6v2ODww2z9k4vGY=; b=sDdRhgT5PjKss1IyJgM7tKmCVRgv1F A+wyB7iywiu0aRUn6M0S73asKUKtY7R4dAWast1itronoYrqP+bhZiBsVhq0zjce iFiIMKCXjpwhgmBEmTbMy2VQVBG6iiNkjArwm02UPZP8j73elufi4recyBN+4JMP /7Fd60RDgu+3sHptSvtVZC4K0vU65LmaqSX1zwzrFLTEtt2cVPybeJfgYOXC6OuY ENZIYQDGP1MP9zYCslQFCBePqLof/G7zIWd2QFzpKOHf/vRz8BiEd8Xa/YMHxswn QL5xVzn0dlI3+KM3OucWgAa/+3GBE9p/HdFJ5kPPfWzdXiAX7oMXarTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=HC7QihwpxyeOWby25T44pPUvZBNZ6v2ODww2z9k4v GY=; b=kY7WmGl0Hf7/Hr+hGFNI82hTeU2icNjd64Vc4QBevRb6AABVjhmVozaIn 0xqMi0wxZWMTQkK3I5iDzSq8H+neStA2dy71KH9Rm2rz44xi/k+Wi7GBXSmf2SgT 2LLIlqBaY0Ma/ApqxiHLWlNHyw/TEn39Nv5xMYZYLIhtUjkTd68rTwVjL6h3iwMb E5scQZj+SS7tFOFkE9LGtag2HSf61FvuBNOxx7IO91gyipjRtuixT1QPgq65imac S4/d9ek7SweYM+pTWrkzUhnC4tfCKCYgfqXY9WGWDG6dTKsJMzGEbYHiajAVKchy /VTRFN2kkpsaf8Bbb708ZEPPazV1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeejgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtjeenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepieduueejhfeufeffffffkeeitdfhleeuffeulefhkeehueejffefgffh ffffteffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Feb 2022 13:36:56 -0500 (EST) Date: Thu, 3 Feb 2022 10:36:55 -0800 From: Andres Freund To: Etsuro Fujita Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Further fix for EvalPlanQual with mix of local and foreign parti Message-ID: <20220203183655.ralgkh54sdcgysmn@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-02-03 06:22:58 +0000, Etsuro Fujita wrote: > Further fix for EvalPlanQual with mix of local and foreign partitions. My compiler (as well as cfbot) now complains that there is an unused variable, when building without assertions: /home/andres/src/postgresql/src/backend/executor/nodeForeignscan.c: In function ‘ForeignNext’: /home/andres/src/postgresql/src/backend/executor/nodeForeignscan.c:47:21: warning: unused variable ‘estate’ [-Wunused-variable] 47 | EState *estate = node->ss.ps.state; | ^~~~~~ Seems best to just use node->ss.ps.state instead of the local estate variable? Rather than using the noisier PG_USED_FOR_ASSERTS_ONLY. I'll make it so, unless you want to? Greetings, Andres Freund