Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHmsk-0005Db-6e for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Feb 2022 13:19:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nHmsf-0003n8-Ne for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Feb 2022 13:19:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHcBN-0005dH-Kp; Wed, 09 Feb 2022 01:54:09 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHcBG-0002oH-Vf; Wed, 09 Feb 2022 01:54:08 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9F92C5C012A; Tue, 8 Feb 2022 20:54:01 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 08 Feb 2022 20:54:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=shZCKFSUdmihlO2up4tsjlNslqAC2l48vFYEOT CkvOA=; b=Q8aaXjvttiXU8DiBOluW9se+yMEoq6BSx+jDcuA67PTDUXRmMH4n10 v4uZU28dHjb+tE3iuLv74UT3+VHotO2PlpZ7sUHBE7iPgja63AeUo+UiERrCrEAL h/3EkQZEGH4DFd9ulp+Le+kg0UIISPfyfbsJrSoQA9ecRMo24EQmrfuOj5XKLUoR hNkM1IckTO0Rb2FHt+gzDTx1Fa7987C3ilr6RnndhNc/bv5Wd6y4fJe4dokznb95 nqrhRxqid5Aiy46WJJqpZZV8O7r8drpcgVLFBvkQ2mtAMhj0WqIO/CSBT73s6M2J rYVTyQ/4gYcUKY/HYdzaxMUwfznf1SNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=shZCKFSUdmihlO2up 4tsjlNslqAC2l48vFYEOTCkvOA=; b=HSGRdFtnRPAipj+DW5TX1OFhyrITMiOqH hFwaWKpXVpk361KERSG8cBsIjPdHh1jJiuUODF1t8SkhLHuRnWP5g88sdb9zx9zN 6yK5ocb23OTIntGF38Bj6E2HPLEFhOKcczyeddIop3NMmiMfO8wbcm0WT81Gt6uS JybokPm21ExjkAz4f+VWCscKjqCdelFDKIBwImSorKb7oNwyEPUumVopXwOOyNYr DVu84EZEP9YXASbpT/iWNkbE2hhx6NoJ3+bNBvd/BVI/1bBAecZ3wkFidDlt0FG4 57tw/YVVADQmobrbfCthnYrZyrlnCZIdlWjf0s7pH8sukoGq4HsrA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheekgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughrvghs ucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrfgrth htvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeffhfeu ffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Feb 2022 20:54:01 -0500 (EST) Date: Tue, 8 Feb 2022 17:53:59 -0800 From: Andres Freund To: Tomas Vondra Cc: pgsql-hackers@postgresql.org, pgsql-release@postgresql.org, Noah Misch , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR Message-ID: <20220209015359.wvstb5rxzj53zrtp@alap3.anarazel.de> References: <20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de> <40d0a4c8-de56-7710-5197-1304fa156aba@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40d0a4c8-de56-7710-5197-1304fa156aba@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-02-09 02:25:09 +0100, Tomas Vondra wrote: > AFAICS this only affects builds with CLOBBER_CACHE_ALWAYS, and anyone > running such build in production clearly likes painful things anyway. Yea, realistically nobody does that. > But really, for the infinite loop to happen, building a relation descriptor > has to invalidate a cache. And I haven't found a way to do that without the > CLOBBER_CACHE_ALWAYS thing. Phew. > Also, all the November minor releases include this commit, and there were no > reports about this (pretty obvious) issue. Buildfarm did not complain either > (but an animal may be stuck for months and we would not know about it). Ah, somehow I thought that wasn't yet in the last set of releases. Phew #2. Greetings, Andres Freund