Date: Wed, 9 Feb 2022 18:35:37 -0800
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
	Thomas Munro <thomas.munro@gmail.com>,
	pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl
 start" f
Message-ID: <20220210023537.GA3222837@rfd.leadboat.com>
References: <E1nAIWI-0006et-HW@gemulon.postgresql.org>
 <CA+hUKGKV6fOHvfiPt8=dOKzvswjAyLoFoJF1iQXMNpi7+hD1JQ@mail.gmail.com>
 <855583.1642687119@sss.pgh.pa.us>
 <867290.1642689136@sss.pgh.pa.us>
 <20220120192736.msyesvdlljn6tptw@alap3.anarazel.de>
 <926839.1642708567@sss.pgh.pa.us>
 <1075553.1642717844@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1075553.1642717844@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20220210023537.GA3222837%40rfd.leadboat.com>
Precedence: bulk

On Thu, Jan 20, 2022 at 05:30:44PM -0500, Tom Lane wrote:
> I wrote:
> > What I'm thinking of doing is inventing a "soft_stop" variant of
> > Cluster::stop that won't complain if pg_ctl stop fails, and then
> > having 017_shm's poll_start() call that before retrying the start
> > call.
> 
> I did that, modeling the details on Cluster::start's fail_ok option.

On AIX, this pair of commits added 5-10h of runtime to 017_shm.pl.

Before 6c4a890 or 4fdbf9a:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2022-01-19%2020%3A41%3A47
[21:14:17] t/017_shm.pl ......................... ok     7360 ms ( 0.01 usr  0.00 sys +  1.62 cusr  0.71 csys =  2.34 CPU)

After both:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2022-01-21%2021%3A03%3A28
[07:52:31] t/017_shm.pl ......................... ok 36908794 ms ( 0.00 usr  0.00 sys +  5.16 cusr 16.04 csys = 21.20 CPU)