Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIyjX-0001JX-3u for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 20:11:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nIyjV-0006g3-Ne for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 20:11:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIyjT-0006UM-Kv for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 20:11:01 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIyjM-0003Ms-5T for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 20:10:58 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A72523200973; Sat, 12 Feb 2022 15:10:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 12 Feb 2022 15:10:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=ZZRyGri1FRerCwH5uHLs91S3F5etKWKhXgFeAx OsllI=; b=FjehDRAZiyz5zT1ZxHGyCXUSuW2yCvUnRvHbdx1PytubeB2OKv5FDU pS2ktahZQYyEK2DrZ5S63XzErGJPgK0BY3vBf/ev+/r7rFTmOBU/9FnxI1RoP8Yg FHQGGWA1RAm4LDNJrzA59eed/qwNe9oAhtWLL1pJzbkfzXCQ4rzxZT00dd2kT+mx XRpR1gaotFFgTRdeF8xqoJG6w5MUvfM5ymVarY/3vBFnPCSsJGjgCZ4Pkxqlhjzr uakGvVzcEry1fzueWXTsEIfFND/z35RK4xgIXyZffqFdcVh6Dttzgw6P5QmJHGcs tKKXenUBDMBx8NN6hdvKgmgHobQGeIow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ZZRyGri1FRerCwH5u HLs91S3F5etKWKhXgFeAxOsllI=; b=axr4m8gW0Wd5JVRwEnKODkXEnfmc7CLI4 4DS4ZlAhcdN+Oc19ePy93FzgDTuyRbxrHFKuv5EoLvrHlgVaCCBo0MYMMNkHhhaq J4Jn4psr3O3ElsXC4DrkbH6rF1eV0QOzZtaNWkHxNp58EO+D5YJYhK67v8m1zJti /4rQH5Y/vokG75s0FfUUxvGZNnMi1s0CtEJPKdRXkCFoxOOXkAehhpAZeQWG6VaK fw/4ekQDW7YqvvbMIuclqNvepiLlk24hfWN0oqEK4JhlOewRHINjFh0eezts+PiF EYfrDIOenooZ2d24Qbhu0ls6bMsqFcDd6yAQoHsWMf3hpWFxXbebw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieehgddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedukefhkeelueegveetheelffffjeegleeuudelfeefuedtleffueejfffh ueffudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Feb 2022 15:10:48 -0500 (EST) Date: Sat, 12 Feb 2022 12:10:46 -0800 From: Andres Freund To: Michael Paquier Cc: Tom Lane , Justin Pryzby , Christoph Berg , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc Message-ID: <20220212201046.uyc2yootpaguph3o@alap3.anarazel.de> References: <2023925.1644591595@sss.pgh.pa.us> <20220211153549.GE31460@telsasoft.com> <2027230.1644594087@sss.pgh.pa.us> <20220211172929.GF31460@telsasoft.com> <2079693.1644600871@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-02-12 13:29:54 +0900, Michael Paquier wrote: > On Sat, Feb 12, 2022 at 09:49:47AM +0900, Michael Paquier wrote: > > I guess that it would be better to revert the TAP test and rework all > > that for the time being, then. > > And this part is done. You wrote in the commit message that: "However, this is also an issue as a TAP test only offers the build directory as of TESTDIR in the environment context, so this would fail with VPATH builds." Tap tests currently are always executed in the source directory above t/, as far as I can tell. So I don't think VPATH/non-VPATH or windows / non-windows would break using a relative reference from the test dir. Greetings, Andres Freund