Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0VD-0002eN-19 for pgsql-committers@arkaria.postgresql.org; Sat, 12 Feb 2022 22:04:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJ0VB-00005r-Tq for pgsql-committers@arkaria.postgresql.org; Sat, 12 Feb 2022 22:04:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0VB-00005i-Mc for pgsql-committers@lists.postgresql.org; Sat, 12 Feb 2022 22:04:21 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0V7-00088e-85 for pgsql-committers@lists.postgresql.org; Sat, 12 Feb 2022 22:04:21 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 444AE3200D30; Sat, 12 Feb 2022 17:04:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 12 Feb 2022 17:04:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=ZN0I/UDvKyBI7pNWXTsATAlvDap09jBdGJJshY VZpYc=; b=AdQ9F3l7rHLAqn9iZFujtjrQJZz1NycIqpN20ZSYpf09VWH3YfVsMk Tn905rU/zQFTw3tncRXz+gg7fUekXx8LVJyeyxmKjr7REmrv25H2IJ4gdTl/tb4e TuWPkjX9sHuHAqEnKku63qvP6ub7lkfuBpDFsCtXLP3l7i9i7RW6LJgqtd/JxH3u r+GMYTMcv7YoHsUQ13yPmWPmt34eV05jCRr7Vuoob5pJc5iw5DkXpNHIDePJgHcT ryewvPJI7cjc0IuilBPxjDtQAOQmoWyV9YO9ulTaJrJGHYgaxynA/HIcwYz5/LzC 1tWL1z0XjRJVHYEWxrzsFOHLLYdJxNTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ZN0I/UDvKyBI7pNWX TsATAlvDap09jBdGJJshYVZpYc=; b=UPCXb+2Fu7kyNMB2COK7Ln+Lkok5+roOe PtvlUM/UnQLdE1AjBYaKPWZpZpOJCCQMtj2SH7AcjZUZEEZfzH8yTTT3Ok/V+mRY xJS0oshOSGdyYh6uEPLUqoQJFhbIWHC2PJ9/ecxJvq+IUrZltYRLDg4BTtssRu0q 4GQeNVVFqd4HD4ZssKnSnuKFrnsQnO8k0gZrgfd/dsg9jPZ/ICK5YAFCN6noC9E6 JQvN3cMk7c9fMrUEWVxh5k0FpdgHzKKA9KYzzPpe1uOtswFd8FuWaFj97QedEisF N0Rh/UM0mq3pY6EHfAVsSrSjCYATv5P1TQEljLg+gcDvj0cV2ADIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieehgdduheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpeehtdevjeekteefjeejfeekkeettdefudehudeigeduieefieejtddugefh iedtueenucffohhmrghinhepphhoshhtghhrrdgvshdpphhoshhtghhrvghsqhhlrdhorh hgpdhpghhsqhhlrdgsuhhilhgunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Feb 2022 17:04:14 -0500 (EST) Date: Sat, 12 Feb 2022 14:04:13 -0800 From: Andres Freund To: Tomas Vondra Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add decoding of sequences to test_decoding Message-ID: <20220212220413.b25amklo7t4xb7ni@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-02-11 23:52:20 +0000, Tomas Vondra wrote: > Add decoding of sequences to test_decoding > > Commit 0da92dc530 improved the logical decoding infrastructure to handle > sequences, and did various changes to related parts (WAL logging etc.). > But it did not include any implementation of the new callbacks added to > OutputPluginCallbacks. > > This extends test_decoding with two callbacks to decode sequences. The > decoding of sequences may be disabled using 'include-sequences', a new > option of the output plugin. > > Author: Tomas Vondra, Cary Huang > Reviewed-by: Peter Eisentraut, Hannu Krosing, Andres Freund > Discussion: https://postgr.es/m/d045f3c2-6cfb-06d3-5540-e63c320df8bc@enterprisedb.com > Discussion: https://postgr.es/m/1710ed7e13b.cd7177461430746.3372264562543607781@highgo.ca The tests fail on slow machines (valgrind in this case), with some spurious output differences: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2022-02-12%2010%3A24%3A22 diff -U3 /mnt/resource/bf/build/skink-master/HEAD/pgsql/contrib/test_decoding/expected/sequence.out /mnt/resource/bf/build/skink-master/HEAD/pgsql.build/contrib/test_decoding/results/sequence.out --- /mnt/resource/bf/build/skink-master/HEAD/pgsql/contrib/test_decoding/expected/sequence.out 2022-02-12 00:40:25.431913374 +0000 +++ /mnt/resource/bf/build/skink-master/HEAD/pgsql.build/contrib/test_decoding/results/sequence.out 2022-02-12 11:07:19.177487256 +0000 @@ -263,12 +263,14 @@ data ----------------------------------------------------------------------------------------- BEGIN + COMMIT + BEGIN sequence public.test_table_a_seq: transactional:1 last_value: 1 log_cnt: 0 is_called:0 sequence public.test_table_a_seq: transactional:1 last_value: 33 log_cnt: 0 is_called:1 table public.test_table: INSERT: a[integer]:1 b[integer]:100 table public.test_table: INSERT: a[integer]:2 b[integer]:200 COMMIT -(6 rows) +(8 rows) I don't think it's a good idea to use skip-empty-xacts = 0 in tests, there always can be an autovacuum or such. Greetings, Andres Freund