Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0a1-00034c-3W for pgsql-committers@arkaria.postgresql.org; Sat, 12 Feb 2022 22:09:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJ0Zz-0006m1-Vj for pgsql-committers@arkaria.postgresql.org; Sat, 12 Feb 2022 22:09:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0Xa-0002cs-7Q for pgsql-committers@lists.postgresql.org; Sat, 12 Feb 2022 22:06:50 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0XW-0004JA-PW for pgsql-committers@lists.postgresql.org; Sat, 12 Feb 2022 22:06:49 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 89B983200C6B; Sat, 12 Feb 2022 17:06:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 12 Feb 2022 17:06:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=GYS6wX0b0rgg+Q7ds6jN9unH4y4+LkT/N9XSH+ baU/E=; b=zHwThT3fpZ5R4gBZDuMTYzGxkh66O4VhmK1ZV0nM5HmmQiBd/yiDUQ I7t9qhXM8Ncmak4/MQ5WyCBNSWLm80Ze7rp85N3OOMc51+VlM0FWBVpQC9eMz7k+ qti90LGwin0MeRj7xJre8VIlAb8813qhcEQUrbXMPh9glX900qkJawEhav+VOii+ OGUMzKx+vP+knT9IS4hBtCarZyE3dipkDw66/uIkfFQV8SzO6kC8D4A9nbSVCdE5 +t2c/AQKdpJU8nMUFQBZpq7kV59ITswWMRQi41ICOZmResz/B48zYkDDg21wINqH BOgdXhqClg6lZtvooFs6+cIoBTndtePQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GYS6wX0b0rgg+Q7ds 6jN9unH4y4+LkT/N9XSH+baU/E=; b=AH94IYmu5tBJ5Jyh3b2PghjtRfLy/AwRO quMeoeczE55yXadLrHNcKcVCH2O8rFR1JpL6CW8R2Qi0qbm+lL1vXLQKK7B8LV2Y pIbFzn0xBd+hxNDnDFvqV4HMx4TBcQTyxCwyKWuqOO1MmYp8B2xYYwfDG0P729t2 QaVmbbme8f11sagqMHPNFOu7TmAcDGWHu6GUP/eYTe+xp9Skx346T5a3PqbKaSG7 xoPCy4p9yjdqTFXPwRaexnqyaarYGU+5P3URntO+y+QAKDT4cO61IXvyACM8mwqc d3GwYWdffAG5wkEIaAMPaO1ZHu7KSJ7JB2gASolaQmAcak0XTCxYw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieehgdduheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedukefhkeelueegveetheelffffjeegleeuudelfeefuedtleffueejfffh ueffudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Feb 2022 17:06:44 -0500 (EST) Date: Sat, 12 Feb 2022 14:06:43 -0800 From: Andres Freund To: Michael Paquier Cc: Robert Haas , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression. Message-ID: <20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-02-12 13:38:45 +0900, Michael Paquier wrote: > Perhaps you'd better check that 'decompress_program' can be executed > and skip things if the command is not around? Note that > 020_pg_receivewal.pl does an extra lz4 --version as a safety measure, > but 008_untar.pl does not. Actually executing the command doesn't seem useful? It doesn't seem useful to ignore an executable that's not actually executable or such. Testing whether the file exists makes sense though. Greetings, Andres Freund