Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0a1-00034b-3A for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 22:09:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJ0Zz-0006m2-Vi for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 22:09:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0Zz-0006ls-MU for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 22:09:19 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0Zx-0008BE-HR for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 22:09:19 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 6324F3200B8B; Sat, 12 Feb 2022 17:09:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 12 Feb 2022 17:09:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=/oADGRUe1OYUNQswL5FoyzQAH1Kaxc3KL0M8yF WWieg=; b=YycaHeIqzxsylIYikjUtUvUrdJsq+niMk0hvnmNm8oaajrxp1a3P/O /5r6j23pVUfXmU97YlDBJRwoOza93dr+O2Cie8tf0lT3RBz5qE8ZwredijewwulG c5XywtIP0DPdxVfiSbCgaxboevvYSnrTmVjBOO7KTJPtT9rJkZD/ylF0kAayzXRP eb+2ntlBSI1KQilawb6q35ZOi+dFTDTNIYaQvsoagq00vXQjr9ujKbwv1ZdHV9YW 1lNZD2J9+EgdnFcbOJt2Y+VLjDilqmPnG0MWqc/H/A+Aamgl6NJqD1rwWWaIc/JF +LXjx0bCb8a9kdJcfTM6vWpscxUCkevw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/oADGRUe1OYUNQswL 5FoyzQAH1Kaxc3KL0M8yFWWieg=; b=DyLFftIUPVfDnkOB2/xTGuIdLlMrxQvG5 VMcct4U+hrEU4Gl76/+NLPfsKEa3Xr4pLbILzr7q8FVz5FMldVi30UoZS1RTM7gv ySe2DiSi1lKvkAq1G6FlJnNmekxrvVsnyeF5WjoX74VyF5Dt+1qxKZGXQ4bpa77/ aVPVi7E7AJic6t+xzMNhrQgaxzgD8M3cFIc34nxc0sdRWgF2Vr4gPbaTTcPRB01X ZXfwE1NDj+SMUf2YZIlB4rumTkhp6dFHQ/xBMi0DgBFRJU5AmTgF+4QeN6D6erjU pBd/XJUK3SrGfPPCylUJNS/ShamAKs6XXI3CM1soPQTLA9S7VCxRw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieehgdduheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedukefhkeelueegveetheelffffjeegleeuudelfeefuedtleffueejfffh ueffudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Feb 2022 17:09:14 -0500 (EST) Date: Sat, 12 Feb 2022 14:09:13 -0800 From: Andres Freund To: Robert Haas Cc: Michael Paquier , PostgreSQL Hackers Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression. Message-ID: <20220212220913.wnhgd7ak32srcmzo@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-02-12 07:24:46 -0500, Robert Haas wrote: > You may be right, but I'm not entirely convinced. $ENV{'LZ4'} here is > being set by make, and make is setting it to whatever configure found. > If configure found a version of the lz4 program that doesn't actually > work, isn't that configure's fault, or the system administrator's > fault, rather than this test's fault? I don't think there's an actual configure check for the lz4 binary? Looks like a static assignment in src/Makefile.global.in to me.