Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK6af-0000k8-4J for pgsql-committers@arkaria.postgresql.org; Tue, 15 Feb 2022 22:46:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nK6ad-0002yY-GX for pgsql-committers@arkaria.postgresql.org; Tue, 15 Feb 2022 22:46:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK6ad-0002yP-90 for pgsql-committers@lists.postgresql.org; Tue, 15 Feb 2022 22:46:31 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK6aa-0004n9-B1 for pgsql-committers@lists.postgresql.org; Tue, 15 Feb 2022 22:46:30 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 232E43200F9C; Tue, 15 Feb 2022 17:46:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 15 Feb 2022 17:46:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=g0Zw1uyFsPf0r9Xy+R5wmjU4xJr/6UAwSxA71y kZNR0=; b=EwHgSfhnPGDmaBWL4HB4jrIyn7rkMyysBdvl66D+oHBK4GzEnXxVWI Zjz/XUrL59QkBRxGFgnqxb2xYCR+DGqcGE70Lie2IePSefjtL+N5Ko9rDmriW3dp TomLMF2kTB+cSecn/6FiNQJaRmzDzdxYR4I9YHEW533AHW2IhkrKwNeQqw72iZBc wax+mTIFnDDGMQ3G58T6DOpnHRjAIeIp2oH5Dl8GwlzChvHqXf2JiUoxVMgCYBC6 pewrmt4ybk6xmLAk56QtRwMM0J6pLwCFvBkA7xrRVplTVUcpMsvvGj9eZVuKH19u ObG26N7Cm2iEZhbHFdcPH25UUyL51WhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=g0Zw1uyFsPf0r9Xy+ R5wmjU4xJr/6UAwSxA71ykZNR0=; b=JladoV9xW7U3eAIJESfNKQKfb4Uk5SJE2 rXpi1tkPlBLqwBvhQLke3uRf/PIlczuI0JY19DaLL4aH9LJprDc+Jc5ycrvFdfYa AGuPJ9sijYv+bMGumZKGBOxPeAJVRG0gQdVj0LYIejtgKW2hrwuYhtMs4+/XSwBG EQy5TT5SHet1mTn/pV6ZqvCvwxLg8ITw5Rao+pK5VNU6eVKdMF16O2cX5t+53wXP Dx/+fCFWO+O/wgu2ekeiTP1+UDih0j4UKIktrtl1ljQj0XQ2sELXx6dJaDRCdXt/ HHxxxzvIS2lunWr+hM0hGq856nVRy3IcmyhFSdSQI4KL/4v4/fCow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjeehgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttdertd dttddvnecuhfhrohhmpeetnhgurhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgr rhgriigvlhdruggvqeenucggtffrrghtthgvrhhnpeetudejgfeileekgefgleevfeehte elteekkeejgffgveejleefgfetueeuuefhkeenucffohhmrghinhepghhnuhdrohhrghen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurh gvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Feb 2022 17:46:26 -0500 (EST) Date: Tue, 15 Feb 2022 14:46:25 -0800 From: Andres Freund To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Ensure that length argument of memcmp() isn't seen as negative. Message-ID: <20220215224625.poqi7mrwtkhcsdpv@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-02-15 22:28:23 +0000, Tom Lane wrote: > Ensure that length argument of memcmp() isn't seen as negative. > > I think this will shut up a weird warning from buildfarm member > serinus. Perhaps it'd be better to change tsCompareString's > length arguments to unsigned, but that seems more invasive > than is justified. Just FYI, I'd reported this to gcc some time last year https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100442 and then forgot about it. They're not wrong there is the possibility of exceeding the bounds, but the error message still is quite confusing. Greetings, Andres Freund