Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKMSG-0007lC-6S for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Feb 2022 15:42:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nKMSF-0005ZC-1i for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Feb 2022 15:42:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKMSE-0005Z3-OY for pgsql-hackers@lists.postgresql.org; Wed, 16 Feb 2022 15:42:54 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nKMSC-0000Rp-Dd for pgsql-hackers@postgresql.org; Wed, 16 Feb 2022 15:42:54 +0000 Received: by mail-pg1-x52e.google.com with SMTP id f8so2468910pgc.8 for ; Wed, 16 Feb 2022 07:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SjlXN/mF8EkcIc8ieXl1lgEogyhbZzAFef9z8lSHbHA=; b=VZCYeAdBg7BjZ1tR78P4o3yHhwhayilb8xLgQwm1bfi8P2dB9pEGrSOhTcY9FKUUeQ zKseqPw88PIBwKpzrTkfC8QhZiB+VYl9BJB/M0nh1gjXpGaXDR2WhvDRkMEH5fQQHaK+ Jy7KOpQ2GnM1Hj7Eqn70ajNoE4jMA4Juog3JTQBFNixKtRzi8cWQ6XrWDv2guI34Wi10 nKZGc3fRUHRx3F9MBVS0SR2VfYabaQ5SzzWjtrMVuql7FIPHVdE+Iiwu2Ev15vaCwBID DosfR6VCQ0odwXd5Y8KI829LcVQ/7Dtg7oXZd1lLXLQ1lQvLPr8bDenNvsBKzNn4/w1r tuHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SjlXN/mF8EkcIc8ieXl1lgEogyhbZzAFef9z8lSHbHA=; b=H2GeZqlXLMW9E8o6W18xmoWiqmYIYM9hL1LtxwIuLSvkUZkltCh2wL+RKlaG1GaYAL USlbMEdQXP3lK6FxCv2a08Ghs7QWgU6YIP8fcdeDQKLMw4HCbm0GMSwZFQygTroLSWdH tXgV00I8MiNa88VAUkpTFkau+6Eoi83DNfEGhgrHtEmqc5yJKLDSXImlJP3k9mcsJ6gd dcNTV16PDWdx6jsVIxprk0zFHzGylCYVpLX+zOU2pbwFRjN+V9LoX1E73T7gYT+PnQ8d 4Y3vynOndvQZq4Jh52dB/UXGxG32oCWBnpCQOn8Qo2TeF7oEnoN2u37oRgrKnpEFDxOl hg/Q== X-Gm-Message-State: AOAM531P4WWnSBIZKOe2m+0hGj383ozqg0aMs0fkOh2tvS9/Qtp8vV4t VapTQl/dao3+TiYbKTqhPvU= X-Google-Smtp-Source: ABdhPJxum9K4NK9qa5ylQv/mW2vicCZgwGR1Dvj7ld3F6n3jDzwWsiFybF4+rq7MyMm/wCmQkQfn4g== X-Received: by 2002:a05:6a00:7c6:b0:4e1:799:7a2 with SMTP id n6-20020a056a0007c600b004e1079907a2mr3698856pfu.25.1645026170402; Wed, 16 Feb 2022 07:42:50 -0800 (PST) Received: from jrouhaud (2001-b011-1005-1e7d-c8d8-bc86-9300-45e3.dynamic-ip6.hinet.net. [2001:b011:1005:1e7d:c8d8:bc86:9300:45e3]) by smtp.gmail.com with ESMTPSA id o1sm5761411pgv.47.2022.02.16.07.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 07:42:49 -0800 (PST) Date: Wed, 16 Feb 2022 23:42:46 +0800 From: Julien Rouhaud To: Robert Haas Cc: Peter Eisentraut , Joe Conway , PostgreSQL-development Subject: Re: pgsql: Move scanint8() to numutils.c Message-ID: <20220216154246.s2zbaakmzmurozvs@jrouhaud> References: <58cca3e9-53b8-e824-7cd4-6e59b4e242b1@joeconway.com> <77f5b16f-cabd-e7e2-db9e-e3e41ff8eec6@joeconway.com> <288c1f67-ba83-dec4-5830-c7cc7762da39@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Wed, Feb 16, 2022 at 08:24:31AM -0500, Robert Haas wrote: > On Wed, Feb 16, 2022 at 6:09 AM Peter Eisentraut > wrote: > > I don't think we have ever systematically release-noted backend API > > changes. I don't know whether that would be useful, but a complete > > treatment would be a significant effort (speaking from experience of > > porting the mentioned pglogical between major releases). > > Personally, I don't think I would ever have used such a thing if it > had existed, because looking through the git history seems more > efficient to me. The release notes can be wrong or can fail to contain > enough information to fix whatever issue I've encountered, but the > offending commit always tells the real story. It sounds like Joe may > feel differently which is fair enough; I can only speak to my own > experience. Agreed. I have been maintaining extensions for quite some time and the commit log (and possibly the referenced discussions) always contains everything needed to fix whatever code is broken with all the important details. I also try to rebuild my extensions regularly against the current HEAD, so at the time the release notes are written they wouldn't be of any use anyway. The only reason I see to have something in the release notes would be to warn about a problematic API change, which doesn't result in hard compilation failure or something mostly immediate like that.