Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUMQS-0004F2-0v for pgsql-committers@arkaria.postgresql.org; Wed, 16 Mar 2022 05:42:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nUMQQ-00033t-Sa for pgsql-committers@arkaria.postgresql.org; Wed, 16 Mar 2022 05:42:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUMQQ-00033k-LZ for pgsql-committers@lists.postgresql.org; Wed, 16 Mar 2022 05:42:22 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nUMQN-0003nc-VO for pgsql-committers@lists.postgresql.org; Wed, 16 Mar 2022 05:42:21 +0000 Received: by mail-pf1-x436.google.com with SMTP id l8so2528262pfu.1 for ; Tue, 15 Mar 2022 22:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=jQ9V2droXdNrcdVACg48+hJmweNc0QuJz4XPEVe2Bd8=; b=VCUDPvdAiZixWL3fhCDy6Fgq+qou0NSgqmduJWX4LIX/ysQs321U385XtWk8t/+3TX DMWZXtl+7/YS5T+5BbHbyxQXG9MCTwONW7sf+Szcf1U/BvzYoRsa3Fcxnkv0BVHEZZh1 BspdsRooRkOxgE9sczSr7Csxz3SyN2zNnUaDB8vEKI8yA3/v4zB6pwSwpdgkb2cGYqjQ gvBnlLulfqesnI74EhDlt7igUX4I1Du4/Tl+m7IVXqntxd9/A4IgH4S1l8ic5kBR9rH6 q4DkCbgXHETonfkvV6yviWicm4c5Bi78rPgghEEwK/fLpHhGfJk9eEfO7UMadFyhbhSJ Q/lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=jQ9V2droXdNrcdVACg48+hJmweNc0QuJz4XPEVe2Bd8=; b=mOqnTec54Q7deCiQ4qJn57gh31ENSDjcxMgLARQdVqhMFsnIKYgcG7W1Mm6JEvTTbd TP4TKeNjqN7uAMXs5tfn8deyRJ8seuuLbB7GEn/hCmC/gcTfSsTQrAkL6zWHSznGtqt5 mtrCijQha9G4BmHWq9NEBc/kBjafdKMRVDSyadEk+36Rdmnqun7bxhyohJK1PtNObSsb OFSqxC6xIFIXwjAdeVzghhmHf+3+XtiFvF1S3Z1lcbPQwuT5WXNyYmLOUPzXmN+kIMIe QRpePYA02Y5tGIgMknbHwSNbmCcyjMU5OC8d2lfTbH5gdSPLyfItw1Z3946FvzPZukxc Ps4w== X-Gm-Message-State: AOAM531seyy5Jv47rQIttrATaFf9Rk4UkSXFlECaedQT+ti6opnsy0Xa 1ENJflhrX4toj4/RNxuEdBg= X-Google-Smtp-Source: ABdhPJyQCOMqOmI4WGZ4WppPVQ8els9DpzAVDNz4yBbcAXr54UD0Ok8T7Kz6hJCwiqRzjOFWXrNugg== X-Received: by 2002:a65:6a13:0:b0:373:14f6:5d33 with SMTP id m19-20020a656a13000000b0037314f65d33mr27505952pgu.62.1647409339073; Tue, 15 Mar 2022 22:42:19 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id 78-20020a621451000000b004f6e8a033b5sm1179812pfu.142.2022.03.15.22.42.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 15 Mar 2022 22:42:18 -0700 (PDT) Date: Wed, 16 Mar 2022 14:42:16 +0900 (JST) Message-Id: <20220316.144216.300331926466543986.horikyota.ntt@gmail.com> To: thomas.munro@gmail.com Cc: tgl@sss.pgh.pa.us, david@pgmasters.net, tmunro@postgresql.org, pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix pg_basebackup with in-place tablespaces. From: Kyotaro Horiguchi In-Reply-To: References: <66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net> <428075.1647379703@sss.pgh.pa.us> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Wed, 16 Mar 2022 11:13:53 +1300, Thomas Munro wrote in > On Wed, Mar 16, 2022 at 10:28 AM Tom Lane wrote: > > David Steele writes: > > > On 3/14/22 19:31, Thomas Munro wrote: > > >> Fix pg_basebackup with in-place tablespaces. > > > > > Perhaps I'm being picky, but seems like this logic should be wrapped in: > > > if (allow_in_place_tablespaces) > > > { > > > <...> > > > } > > > I worry about strange effects when this GUC is not enabled. > > > > What would happen if someone created an in-place tablespace and > > then turned off the GUC? > > Then it would break with unhelpful error messages. I suppose we could > error out explicitly, "in-place tablespace detected, but > allow_in_place_tablespaces not enabled". I'm not sure why we should > suddenly choose to enforce that *here* though. +1. The GUC is only to prevent non-developer users from accidentally creating in-place tablespaces that is not officieally suported. We have done nothing about in-place tablespaces other than the things needed to perform regression test, and I think we won't do that in future. regards. -- Kyotaro Horiguchi NTT Open Source Software Center