Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVKnV-0004RJ-Ug for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Mar 2022 22:10:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nVKnU-0001hA-1X for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Mar 2022 22:10:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVKnS-0001gu-8G for pgsql-hackers@lists.postgresql.org; Fri, 18 Mar 2022 22:10:11 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVKnM-0000wE-CV for pgsql-hackers@lists.postgresql.org; Fri, 18 Mar 2022 22:10:08 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 256BE5C00E2; Fri, 18 Mar 2022 18:10:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 18 Mar 2022 18:10:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=43FGdpZsfZeLLr01caF4kaa5WjnEg8f7selEHh FIUo0=; b=Mu4h717XILQ4RmDD5GB+zwaPEkN3Cu90ZXEUYHbj4tO87NO/MgISUT 5GP52qvAZh2nWJMXvTfP9isFuUQLQH9ZgBGbE848LS61fhWoafNiat616x9wBMMI JQjyl1rVLtCb718APhs03WBUAqw2aPyITM3bXacRnDlxcGwZ3CvmvrovHC755LqT qxInjFpkT0ShNaJTEK/PavBcw/nhb0KSI+dZNGfh8uVoQEoLju3nPErqMtDLUe/T rThiE18tB8L3iZpNFnB8xj2JXhFa3ThWMsuNsYqz4U+P4SzUMVLf69fdOQH8AVRn mEPFZAYBEUau1S+6NViIEzveSnqh/G0A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=43FGdpZsfZeLLr01c aF4kaa5WjnEg8f7selEHhFIUo0=; b=C+fCQt1h0+dVVLgEbK91EDJBOrBzN5cy2 4uPpyqEuU1aFZgMdq+NhHOwYzTyf+j67VPx+eTYOFOVSCbXfKkzdHBm7ALs+pjzP Mw6NUbocJDtEdNIZWujRrN9cZPlyqMEjSM5IyEgv8S6VxFypJsVkHK4hhtL+488x HXk36cSR1uPZp0KAm69qZDcdZrYjIWy/0cylW1sa4Gvp2Cr+pVigczJ1aUaII41Y rL2fEech0YXJ9vDe+Jja58MBuBpXLL7FNVq2S8lF3GmLakTyiTqeF5Pf9f/oNB4M PPWKEv7ghWfiXgGK+AkHgPWXJ/VXfe7Jg/S2lMjoOHYSIyH75BYBQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudefiedgudehkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeff hfeuffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Mar 2022 18:10:00 -0400 (EDT) Date: Fri, 18 Mar 2022 15:09:59 -0700 From: Andres Freund To: Peter Eisentraut Cc: Julien Rouhaud , Thomas Munro , Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add option to use ICU as global locale provider Message-ID: <20220318220959.pc4hpdmat6gbcdc2@alap3.anarazel.de> References: <20220318031244.tu3wwlyxxabzq3iu@jrouhaud> <20220318063648.4ja6rxlyzvc3viio@jrouhaud> <20220318074051.n46mkwp2zkbxeesf@jrouhaud> <20220318092749.363m4uv6rq24lctz@jrouhaud> <7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote: > Why does your patch introduce a function check_icu_locale() that is only > called once? Did you have further plans for that? I like that it moves ICU code out of dbcommands.c - imo there should be few calls to ICU functions outside of pg_locale.c. There might be an argument for moving *more* into such a function though. Greetings, Andres Freund