Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVNRP-0006Vp-Sn for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Mar 2022 00:59:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nVNRO-0007fW-OC for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Mar 2022 00:59:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVNRO-0007fN-Cr for pgsql-hackers@lists.postgresql.org; Sat, 19 Mar 2022 00:59:34 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nVNRM-0000TT-37 for pgsql-hackers@lists.postgresql.org; Sat, 19 Mar 2022 00:59:33 +0000 Received: by mail-pg1-x534.google.com with SMTP id o23so6186139pgk.13 for ; Fri, 18 Mar 2022 17:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=upWXmzD4OFAa1u9H6FZAT/1lbC8uoK9fTkJIf/UIG0E=; b=huQEqhjlZMvry1k96NxRtQNErtrRq1iIbYQwcrDoweAptt/RQ+82D/AkyNjcFaYZPT KyF1smwai3OHpt8miLRp0nilt5nFVY5QQB2ESSY5PlvRIvNVKnLi1eOaIdhttDydC1bl 2kmjcf487QD8YuL8bt3voq9ApgDM7wPlAr/iCfRcFTADJAfI9p2yyo+zHGfEacTtJ/ww 6rlcmpUMj9ubWT2bTqApOZF7xvceq7of+8DZTgFOWhzTfVZbDGF9LKjlpm2KzLOTq2kH rxMAyuS57eJ3Iv+0EksN9oM2Wwt8ZcDJRbSm24mh4h0eqmlg02L7NZZDE/T0KaLHNu00 1N4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=upWXmzD4OFAa1u9H6FZAT/1lbC8uoK9fTkJIf/UIG0E=; b=U1yUbklXOJscO3bwNWysGJRPerh2R1I0bvsy5DFFqlSnKzH+8vrecJIR/9mDJAq3UX oxC7gNDYfRg+Rl2EmNzoThEpB64gm14yeyI4/1TXxdkbyI1rY1fREc114+SedTlax9IZ Ere2etRGR6wA+pplfYDRAn/EGzLjPoH9oOZUzeWfqUWmmSLaEyjOnzlkdEQcQrGCEWBZ T6d64kR8gSDFZeuJE1MPLhtGIREQldAscOshKwm8jOKz29KbObDkm7w6+vW9NRPXD4ad l8vP0by9h4kLFQO0FVacIv7Mog9cDLgWr1ykWt4arsNhWMkpUQj37GR1MiXzJkNrcFfb 72kw== X-Gm-Message-State: AOAM5309uugQvny3oOzQx5RDW//j2BD8qnVS9GTLSJh0WcrQfrs9WWXT CbxBwALGE8JW6MIfp6pajS8= X-Google-Smtp-Source: ABdhPJxVE4UCcgShwqp3lxUMrQmY6HJRUmWXcMVyUbbxFiIbl5qBq5fSACx28G+5m2CPJ0bExd84OQ== X-Received: by 2002:a05:6a00:1a02:b0:4f7:c25d:2170 with SMTP id g2-20020a056a001a0200b004f7c25d2170mr12958663pfv.53.1647651570881; Fri, 18 Mar 2022 17:59:30 -0700 (PDT) Received: from jrouhaud (2001-b011-1005-9591-25eb-5898-3273-93a3.dynamic-ip6.hinet.net. [2001:b011:1005:9591:25eb:5898:3273:93a3]) by smtp.gmail.com with ESMTPSA id u25-20020a62ed19000000b004f140515d56sm10546691pfh.46.2022.03.18.17.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 17:59:18 -0700 (PDT) Date: Sat, 19 Mar 2022 08:59:14 +0800 From: Julien Rouhaud To: Tom Lane Cc: Peter Eisentraut , Thomas Munro , Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add option to use ICU as global locale provider Message-ID: <20220319005914.4qe656mbhh6a44p4@jrouhaud> References: <20220318031244.tu3wwlyxxabzq3iu@jrouhaud> <20220318063648.4ja6rxlyzvc3viio@jrouhaud> <20220318074051.n46mkwp2zkbxeesf@jrouhaud> <20220318092749.363m4uv6rq24lctz@jrouhaud> <7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com> <1221473.1647633850@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1221473.1647633850@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Mar 18, 2022 at 04:04:10PM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > Another option is that we just don't do the check in initdb. As the > > tests show, you will then get an error from the backend call, so it's > > really just a question of when the error is reported. > > +1 ... seems better to not have two copies of the code. Ok, I also prefer to not have two copies of the code but wasn't sure that having the error in the boostrapping phase was ok. I will change that.