Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVu1d-0003Qs-8z for pgsql-hackers@arkaria.postgresql.org; Sun, 20 Mar 2022 11:47:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nVu1b-0000C8-Rd for pgsql-hackers@arkaria.postgresql.org; Sun, 20 Mar 2022 11:47:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVu1b-0000By-Fl for pgsql-hackers@lists.postgresql.org; Sun, 20 Mar 2022 11:47:07 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nVu1Y-0007w6-5a for pgsql-hackers@lists.postgresql.org; Sun, 20 Mar 2022 11:47:06 +0000 Received: by mail-pj1-x102b.google.com with SMTP id gb19so10932062pjb.1 for ; Sun, 20 Mar 2022 04:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=S/LYqLrDiYcR1R7EzFlEQU4a/sZclob4T7/lXKlyVV0=; b=Xb0a1h/+zlbPzI1kN+eK51FRLuwmz6j8yuG2Y/Cov4Hsrv9LrM2mz5OLdD+PVRAoAZ bEm6W/cd5+xKupkylwc/WSK5lWLmGHhavNkf+PpWzhP502MbjTcnsNanYV1XugScdhJg 7p3ttDYZwJ7xe8qgKy2B97VvZd4eFKZg3FIP5+toc7AgWog9W4462QeKpUYlahiPuoxA wHPaWItig0dsO7UMKcUcwsUbx2VFxsHNiFi9qUYJnVp5ksINKZVQN8FPD9N+U6KM3mUw 7OpjfMAECqNNhWhs9xVX1qHmbNgOsNnyugTmYmOtQpGtY9A11ISUJthf96c7oouRvxkg v0Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S/LYqLrDiYcR1R7EzFlEQU4a/sZclob4T7/lXKlyVV0=; b=kZaxjSBL0P5iDTvkHsxiSZCGtp3VBjTi0uxDu8l3Fuhp0HAhRRPYElCuXXUUkATiFc WfrjCq/6etuH0xTjQTgA8kfRj9NCtFiCEgreom9cDje6me+GZoir1P0nowjU37rEu8O/ KqFYXfLFs1HtfzpzVSgxuowVDpmSpLTByiyCj0Gr8K9/CAW52nQyO2pwV3EOpuNgwYFQ B7tvkDY+VCXm+GA2vm6w0vmH/gSyRTeN0uy5n8g2usjuM9W6JSv60WirL8GSKgLRcWQ4 XqRVLttBK3u6+wRmOUqSBpGV8hVbB32FQBIbLLjla9G0mgLuX1Ti1wPHEKHoRix3sU9Q q/vg== X-Gm-Message-State: AOAM531PTUhTfCn5STOLhGTYeA76+gkUh96ZyGOXU1QPqZVfVwe0Ghgw dNbC4hFnINsc2HKoZDzCbhQ= X-Google-Smtp-Source: ABdhPJz8C/Xkkd9gKcS4oTB11U0jh6+wIkZBj5mH3zhdInS0Pss+hGwk2oRW2O9gf/BozfCOyNJjSA== X-Received: by 2002:a17:90a:1108:b0:1be:e1bd:e2f0 with SMTP id d8-20020a17090a110800b001bee1bde2f0mr20932738pja.144.1647776822913; Sun, 20 Mar 2022 04:47:02 -0700 (PDT) Received: from jrouhaud (1-171-59-32.dynamic-ip.hinet.net. [1.171.59.32]) by smtp.gmail.com with ESMTPSA id b9-20020a056a000cc900b004f7a986fc78sm16370681pfv.11.2022.03.20.04.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 04:47:02 -0700 (PDT) Date: Sun, 20 Mar 2022 19:46:26 +0800 From: Julien Rouhaud To: Peter Eisentraut Cc: Andres Freund , Thomas Munro , Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add option to use ICU as global locale provider Message-ID: <20220320114626.jqqbgg4isfyyefif@jrouhaud> References: <20220318031244.tu3wwlyxxabzq3iu@jrouhaud> <20220318063648.4ja6rxlyzvc3viio@jrouhaud> <20220318074051.n46mkwp2zkbxeesf@jrouhaud> <20220318092749.363m4uv6rq24lctz@jrouhaud> <7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com> <20220318220959.pc4hpdmat6gbcdc2@alap3.anarazel.de> <20220319041459.qqqiqh335sga5ezj@jrouhaud> <8c3771a7-5c73-5ccf-408a-5d6c6c96ebc0@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c3771a7-5c73-5ccf-408a-5d6c6c96ebc0@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sun, Mar 20, 2022 at 11:03:38AM +0100, Peter Eisentraut wrote: > On 19.03.22 05:14, Julien Rouhaud wrote: > > On Fri, Mar 18, 2022 at 03:09:59PM -0700, Andres Freund wrote: > > > Hi, > > > > > > On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote: > > > > Why does your patch introduce a function check_icu_locale() that is only > > > > called once? Did you have further plans for that? > > > > > > I like that it moves ICU code out of dbcommands.c > > > > Yes, it seemed cleaner this way. But more importantly code outside pg_locale.c > > really shouldn't have to deal with ICU specific version code. > > > > I'm attaching a v2, addressing Peter and Tom comments to not duplicate the old > > ICU versions attribute function. I removed the ICU locale check entirely (for > > consistency across ICU version) thus removing any need for ucol.h include in > > initdb. > > committed Thanks!