Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nW34K-0008Hw-Ex for pgsql-committers@arkaria.postgresql.org; Sun, 20 Mar 2022 21:26:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nW34J-0005B9-Ag for pgsql-committers@arkaria.postgresql.org; Sun, 20 Mar 2022 21:26:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nW34I-0005B0-8d for pgsql-committers@lists.postgresql.org; Sun, 20 Mar 2022 21:26:31 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nW34F-0003ul-Kk for pgsql-committers@lists.postgresql.org; Sun, 20 Mar 2022 21:26:29 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 80B59580180; Sun, 20 Mar 2022 17:26:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 20 Mar 2022 17:26:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=Y4oWsw6QalGnHG9wL+NrgKjqQB/buuvywV9JZbIqfLI=; b=nx+/dJ9l +xsuHH5wXezGVjGxor+y5JCgqT+o6ZIWwbcizR6KiPjMOemPC2Cz3n5rTUvbRqZR UhK3rCe+T+u80TpKAvH6EXXjPmzJ2F9ftn1RqMHGf2GqUVfs4V0Dbr7AXtGEgGiV 8hqBUJMz+izztlgOBZEqxGbSf7BPCbAob9Zw+Ce8g76USK+p+cUwlnq9k20i4pp/ XMzwGEFkAq0CIOh9pPAN+XomFlK4H1E1fdm/3W6RZ2Svg8iWjmXlMqdp7IauhNlx K0YvakpyRdR1fLFRRk0fzE5fa1lBB+eQWp2/WAITz07WogMIYTfcD3vW5WiMtTYW u4z6IFSJuLW/eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddgudeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecuogfvvgigthfqnhhlhidqqdfuphgrmhgsohhtqd gkgedvvddqjeduqdgsihhsucdlfedttddmnecujfgurhepfffhvffukfggtggugfgjseht keertddttdejnecuhfhrohhmpeetlhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrh hrvgesrghlvhhhrdhnohdqihhprdhorhhgqeenucggtffrrghtthgvrhhnpedujeevjeff jeevuddutedvkeeiueeitddvieelfeekveejudefgeeuvdejhfeuleenucffohhmrghinh epvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdroh hrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 17:26:26 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 898032A0665; Sun, 20 Mar 2022 18:26:33 -0300 (-03) Date: Sun, 20 Mar 2022 22:26:33 +0100 From: Alvaro Herrera To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Enforce foreign key correctly during cross-partition updates Message-ID: <202203202126.5susqfvj43q5@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1596411.1647808192@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Mar-20, Tom Lane wrote: > ==2663594== Conditional jump or move depends on uninitialised value(s) > ==2663594== at 0x421526: ExecUpdateAct (nodeModifyTable.c:1855) > It reproduces easily for me under valgrind. I guess > ExecCrossPartitionUpdate must be failing to set > inserted_tuple or insert_destrel. Yeah, I was trying to reproduce it -- but it doesn't for me. Strange. Anyway, I think you're right: insert_destrel is used in the test when ExecCrossPartitionUpdate returns true, and clearly it can do that and not set insert_destrel. -- Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/ "La grandeza es una experiencia transitoria. Nunca es consistente. Depende en gran parte de la imaginación humana creadora de mitos" (Irulan)