Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWn4A-0004iL-Hh for pgsql-committers@arkaria.postgresql.org; Tue, 22 Mar 2022 22:33:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nWn49-0005ls-Ee for pgsql-committers@arkaria.postgresql.org; Tue, 22 Mar 2022 22:33:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWn49-0005lj-7v for pgsql-committers@lists.postgresql.org; Tue, 22 Mar 2022 22:33:25 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWn47-0000sx-3P for pgsql-committers@lists.postgresql.org; Tue, 22 Mar 2022 22:33:24 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5CD455C08A5; Tue, 22 Mar 2022 18:33:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 22 Mar 2022 18:33:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=IuHY/ebmMmAsn6heRqRAmNGmJj+fEfPylRCsvK RwMgk=; b=OlU92QE+bBj37Az0s3QUKgX2h5QmHcoO0SoiOZRajN1YYuTwsIs3+h 71C6JOpLvoTbrGd8hJfPmIuxkV+vB5QOmJBE+k5QugEMYBf01IYRaP62aWd9lqHQ /qIpB99FB+YeWZ7fT2VX6UPy8m5kcL5fr6E9R8IaQUzsMQ0RB79w43cTKHb1/KAl cg0L2TE72+4ij4GgUGrPlJLlwzwzottgMqRaM+f2bJYRoSqmfNvREgXva+jG81FX +0graX65e6+wcJgh1bqsHgcbh1tuRzXF1Rkp7jB99jF1cnoG4vahyYAjWuvXsF2Z EjNG+E4rqo0MvUA4qGmV2qLXjeSPJpyQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=IuHY/ebmMmAsn6heR qRAmNGmJj+fEfPylRCsvKRwMgk=; b=XT58soCY1FmOMMQ7lKXWddb0QxN+M2Rhn CjMR8SrldNpo+iwGvry2RGOUUt1mhL0WqUjKtR6qW0fdvxZIXhPWIUMIbHtpiyZx OCFG2hrplGr3DovKRuK0hnAuWv0EWVgHRYus4o8GMeldbguHwXfStu903K/a3acm 9xDMY5jqoBYaRawAmtCx0LIJov7pLVxlypgAV0CncuzFTu3o2Jad8BVDop8fu9Tp 0iKyzVkeqp5MNETyMOVnMIsD8IwSaimZPGx3paRbxeP/zoEvtTGimaJwrLe/QiwJ IxDFe+QNI1mikskeih8xUFNkx8s6IUNpdpheDUNJAFj3hDzjDct1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeghedgudeitdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeff hfeuffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Mar 2022 18:33:19 -0400 (EDT) Date: Tue, 22 Mar 2022 15:33:19 -0700 From: Andres Freund To: Andrew Dunstan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Common SQL/JSON clauses Message-ID: <20220322223319.so4ajcki7wwaujin@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-22 21:34:25 +0000, Andrew Dunstan wrote: > Common SQL/JSON clauses > > This introduces some of the building blocks used by the SQL/JSON > constructor and query functions. Specifically, it provides node > executor and grammar support for the FORMAT JSON [ENCODING foo] > clause, and values decorated with it, and for the RETURNING clause. > > The following SQL/JSON patches will leverage these. This currently triggers a number of warnings. I assume that's because of the following patches not being there yet? How far out are those? /home/andres/src/postgresql/src/backend/parser/gram.y: warning: 6 nonterminals useless in grammar [-Wother] /home/andres/src/postgresql/src/backend/parser/gram.y: warning: 9 rules useless in grammar [-Wother] /home/andres/src/postgresql/src/backend/parser/gram.y:15249.1-15: warning: nonterminal useless in grammar: json_value_expr [-Wother] 15249 | json_value_expr: | ^~~~~~~~~~~~~~~ /home/andres/src/postgresql/src/backend/parser/gram.y:15256.1-22: warning: nonterminal useless in grammar: json_format_clause_opt [-Wother] 15256 | json_format_clause_opt: | ^~~~~~~~~~~~~~~~~~~~~~ /home/andres/src/postgresql/src/backend/parser/gram.y:15268.1-19: warning: nonterminal useless in grammar: json_representation [-Wother] 15268 | json_representation: | ^~~~~~~~~~~~~~~~~~~ /home/andres/src/postgresql/src/backend/parser/gram.y:15276.1-24: warning: nonterminal useless in grammar: json_encoding_clause_opt [-Wother] 15276 | json_encoding_clause_opt: | ^~~~~~~~~~~~~~~~~~~~~~~~ /home/andres/src/postgresql/src/backend/parser/gram.y:15281.1-13: warning: nonterminal useless in grammar: json_encoding [-Wother] 15281 | json_encoding: | ^~~~~~~~~~~~~ /home/andres/src/postgresql/src/backend/parser/gram.y:15285.1-22: warning: nonterminal useless in grammar: json_output_clause_opt [-Wother] 15285 | json_output_clause_opt: | ^~~~~~~~~~~~~~~~~~~~~~ Greetings, Andres Freund