Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWxaP-00054B-SD for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 09:47:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nWxaO-000414-IX for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 09:47:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWxaN-00040v-GA for pgsql-committers@lists.postgresql.org; Wed, 23 Mar 2022 09:47:24 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWxaJ-0000JZ-Lm for pgsql-committers@lists.postgresql.org; Wed, 23 Mar 2022 09:47:23 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 233C45C0121; Wed, 23 Mar 2022 05:47:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 23 Mar 2022 05:47:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=lLfgS9WrTFbo6HYQ9IR1m1NTCjwU0iVbmOUR2vpOH/w=; b=NU45lh+d VTrLBORN2XoBgkeA8XfyvjTZ+fqDsqrOjGYcgnhFwmtZkH1RptoxwEnkCgJtPp4+ jEzF5AgnqQt75gHK5kEoVXAoUQvfEOUOdAygW6UL9caye3hTWw2Sa5cATODpHo7a jLJPNQV6YpblvIzDTZGyLaos26o/1U8dQxPxCCEuYt16BxRpHvF8BMAm78kzmB4H AcVFjYKdIByZ795x5b6Dit3IS+yD9cSk+fOApvx05CQmy47Yy4sRbw53Jy1K6QBj 6kVfvDlRgz3nRxQzetKgi8T9UokjzaPsbnYC06UKipMtnO8QAjP/S3tDQ/ehkyuJ hibz/6WwVnbQWg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegjedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedujeevjeffjeevuddutedvkeeiueeitddvieelfeekveej udefgeeuvdejhfeuleenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Mar 2022 05:47:15 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id DFF632A0648; Wed, 23 Mar 2022 06:47:26 -0300 (-03) Date: Wed, 23 Mar 2022 10:47:26 +0100 From: Alvaro Herrera To: Andrew Dunstan Cc: Andres Freund , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Common SQL/JSON clauses Message-ID: <202203230947.rz7ll75qxp2f@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9fee834f-ddd9-2adb-0d6f-4ad5af92c12b@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Mar-22, Andrew Dunstan wrote: > Tomorrow, with the SQL/JSON constructors patch should resolve it. So > roughly 24 hours. It's not his fault but this happened because Alvaro > asked me to stagger the commits. Ouch, yeah. This kind of problem can be observed by using something like git rebase -i origin/master -x "make install" this will generate a rebase "todo list" that includes a "make install" step after each individual commit, so you can verify that each commit is warning-clean. (By default there is no pause after each commit if there is a failure; my strategy for dealing with that is to change each patch in the rebase-todo-list from "pick" to "edit", so I can fix any problems, add them to the commit, then continue the rebase.) -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "En las profundidades de nuestro inconsciente hay una obsesiva necesidad de un universo lógico y coherente. Pero el universo real se halla siempre un paso más allá de la lógica" (Irulan)