Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX3E0-0003ax-A5 for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 15:48:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nX3Dz-00089F-6S for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 15:48:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX3Dy-000896-6B for pgsql-committers@lists.postgresql.org; Wed, 23 Mar 2022 15:48:38 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX3Du-0006Fu-IJ for pgsql-committers@lists.postgresql.org; Wed, 23 Mar 2022 15:48:37 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7AA593201FCE; Wed, 23 Mar 2022 11:48:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 23 Mar 2022 11:48:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=K+VxgsnGuZrdwLy6+2YOr77sEKssguvqq2FZ7zbjqTE=; b=iH42Jm8H MJDlkudXy9sWKi9hP5OZxMRblDn4RfmqnMeWzJsk8ei46yLQsgjJK5Tlv6qheXYd V2YpDVAEsG7tPUuLPrQm1CczkZzIxVFzzPnoXl+7vlPNQ83bQ9UYEX3eVx52O/LC O3DWX1o5Npvo8ZVLH2qIo1O/hvxg9aLVD1O3KelariJAQVNzu/VuiANDaSB92KAG AN0s7SllB77+TRKqKeSD9BG+y+tpK7r6Pq2DUYayZmsXUQ5LAZr/OXNwfC2ct+// B37WzehRis9mtkr5AbuT2ItjbZDQCdz3lxzrSI4m39KVZXS9cJ4Higeqxr3G54y3 GFA5p2idImYrKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegjedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedujeevjeffjeevuddutedvkeeiueeitddvieelfeekveej udefgeeuvdejhfeuleenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Mar 2022 11:48:31 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 577372A064C; Wed, 23 Mar 2022 12:48:40 -0300 (-03) Date: Wed, 23 Mar 2022 16:48:40 +0100 From: Alvaro Herrera To: Tomas Vondra Cc: Tomas Vondra , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix skip-empty-xacts with sequences in test_decoding Message-ID: <202203231548.ig7kmnugqg23@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f39ab04-950e-d62f-b413-b07f1b8b36b9@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Feb-14, Tomas Vondra wrote: > On 2/14/22 14:36, Alvaro Herrera wrote: > > I propose the attached comment additions instead. > > The comments seem fine to me (although not really related to these commits > about sequence decoding). Thanks, pushed. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Now I have my system running, not a byte was off the shelf; It rarely breaks and when it does I fix the code myself. It's stable, clean and elegant, and lightning fast as well, And it doesn't cost a nickel, so Bill Gates can go to hell."