Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX3FG-0003fD-CI for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 15:49:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nX3FF-0001rl-9J for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 15:49:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX3FE-0001mJ-7U for pgsql-committers@lists.postgresql.org; Wed, 23 Mar 2022 15:49:57 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX3FA-0006Gw-0F for pgsql-committers@lists.postgresql.org; Wed, 23 Mar 2022 15:49:55 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4FB905C006B; Wed, 23 Mar 2022 11:49:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 23 Mar 2022 11:49:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=rJgtTIELwdGFiKaSpsemmtVCZrpuolbxBUaCGY oNeZg=; b=L5GJLF5R2TKyBtKsvguZOB4vIIVFkfrfxNama4kmPXlI7nig/Mj/OT gCSEC8nrHGsKfDsCK4eqfkVbSVsYbagI4Hw1ZxvqdPtZ3yBbGhU4Ci5hfhm5Mus3 XsqhU5/mPUOWJeY6ViwOBFL9JwzhUk6JlwgqZnNNDHhkOo78QVsfqLBHFqQ4yuC5 YE5S2/T/t9apvMsN0rR0n3iMRyS7itXTOt5ATNF3DSnd0J9r3WbnUimmZ025WKNG xWkpvdRPDwtNmg6sU61JsH2jITp+NXx1h9qRuQY3tteYGBu1d0Bg5izb4hG0DaEk XUrr/ksDiwj3kSk/J4tbF9mVCt0s29yQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rJgtTIELwdGFiKaSp semmtVCZrpuolbxBUaCGYoNeZg=; b=b483mh7nmx6jJn7kD0ck/zCYEC4bvIIg7 WtGelsm3YI63HeLGx7oHVkqvKqcTYk/kSYvOILyuMLlyYZQvG8C/Erbq+nqbj+SC Zy63y0aVtq/+M7fNWHEpUyrJDg7yCpbbU2Q70y7Ggl+nzYFlcF5l0G6MPUzut180 4tMdt1eprArlU4h7UCqLKFoTSzcEi043oNGyJhVUtzhHkMr0FhaT2f8pOAqA3SZ/ vugCZULHfbNUoUCR7VgeEtft7VNRkFGfVU/1Y75vLBz+Dj7xvgx+2U+XBXllbZyH 6vKOVkMMCkqx9WbqKjgnBj97zzcUGimZkDr9wi+9uQ0gzlzR8p1Lg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegjedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffvuffkfhggtggujgfhsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpeehgfeljeehudejieeljeekgfefheejkeeuheetgfejleefteegleduudeh iedvkeenucffohhmrghinheptghirhhruhhsqdgtihdrtghomhenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghrrgii vghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Mar 2022 11:49:49 -0400 (EDT) Date: Wed, 23 Mar 2022 08:49:48 -0700 To: Robert Haas Cc: pgsql-committers Subject: Re: pgsql: Unbreak the build. Message-ID: <20220323154948.izypvuod5ddgyj46@alap3.anarazel.de> [IFrom: Andres Freund References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: From: Andres Freund List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-23 11:38:39 -0400, Robert Haas wrote: > On Wed, Mar 23, 2022 at 10:46 AM Andres Freund wrote: > > There's new warnings that sound reasonable introduced in the prior commit that didn't get removed in this one: > > > > https://cirrus-ci.com/task/5259487073271808?logs=mingw_cross_warning#L392 > > That link takes me to a screen that shows no warnings. Hm, apparently copied the link with slightly off line numbers. Odd. > Scrolling around the only thing I see that doesn't seem to be addressed by > this commit is a complaint about get_bc_algorithm_name falling off the end. Well, there's also the test failure on windows... > I've added a dummy return statement to hopefully address that. Assert(false); won't help a compiler to see the path is unreachable when building without assertions. Might be nicer to use pg_unreachable(). Greetings, Andres Freund