Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXSFi-0005nB-Nn for pgsql-committers@arkaria.postgresql.org; Thu, 24 Mar 2022 18:32:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXSFh-0000EA-JB for pgsql-committers@arkaria.postgresql.org; Thu, 24 Mar 2022 18:32:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXSFh-0000E1-CS for pgsql-committers@lists.postgresql.org; Thu, 24 Mar 2022 18:32:05 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXSFe-00080e-Ut for pgsql-committers@lists.postgresql.org; Thu, 24 Mar 2022 18:32:04 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 51E5E3200C4A; Thu, 24 Mar 2022 14:32:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 24 Mar 2022 14:32:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=JzS+aHzHOn1QIguepQgtdPOOd8Ct3Es93J/N8hMBbq8=; b=Y2it2yKN jWECFlzTd7I/0cFiN7JKFy81PLIKtHHtWqfZdFjNhkTrT88QtdG/GG3dhv+ewAEq dyo1K78AVy0tsVOfieoa6fIGd779R1T4LfTMEvNrBbFESdREA4DsspsjrknX3fNN UGzQP7F77oWa+yerydBQX5Oc4xl/ua67re53TQNYERYw6+BFEEXo/QBCUhYq+DNM arU2TcJnu2mu3W+Uvf9WiRhPf5KvNIH79dPzsVtneS6ha4WrFFnNr+b3ar13ePgz 27XqPl4kQxDmpdKBVwutiOL8cCQq1d6SaDy0EeqGo3dsd0igYdwL5jbFdbqijXK/ ykJnr+Rw/m7gDw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegledguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggugfgjsehtke ertddttdejnecuhfhrohhmpeetlhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhr vgesrghlvhhhrdhnohdqihhprdhorhhgqeenucggtffrrghtthgvrhhnpedujeevjeffje evuddutedvkeeiueeitddvieelfeekveejudefgeeuvdejhfeuleenucffohhmrghinhep vghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhr gh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Mar 2022 14:31:59 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 7E4E42A08E0; Thu, 24 Mar 2022 15:32:13 -0300 (-03) Date: Thu, 24 Mar 2022 19:32:13 +0100 From: Alvaro Herrera To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Change fastgetattr and heap_getattr to inline functions Message-ID: <202203241832.7ojy5mwcbmij@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3029088.1648145389@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Mar-24, Tom Lane wrote: > wrasse isn't happy with this: > > ccache /opt/developerstudio12.6/bin/cc -m64 -Xa -v -O pg_resetwal.o -L../../../src/port -L../../../src/common -L/home/nm/sw/nopath/uuid-64/lib -L/home/nm/sw/nopath/openldap-64/lib -Wl,--as-needed -Wl,-R'/home/nm/farm/studio64v12_6/HEAD/inst/lib' -lpgcommon -lpgport -lxslt -lxml2 -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -ltermcap -lnsl -lsocket -lm -o pg_resetwal > Undefined first referenced > symbol in file > nocachegetattr pg_resetwal.o > ld: fatal: symbol referencing errors > > I believe you need to wrap those new inline functions in > "#ifndef FRONTEND". Ah, hadn't seen that, thanks. Pushed that as fix. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/