Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXrSo-0003Jw-9Z for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Mar 2022 21:27:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXrSm-0002qo-CL for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Mar 2022 21:27:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXrSk-0002q4-6S for pgsql-hackers@lists.postgresql.org; Fri, 25 Mar 2022 21:27:15 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXrSg-0004vy-SN for pgsql-hackers@lists.postgresql.org; Fri, 25 Mar 2022 21:27:13 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 485F25C0190; Fri, 25 Mar 2022 17:27:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 25 Mar 2022 17:27:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=t94kb92TUrnNwgW8z3wcter+WouO8euAqSoDzg tU+Rs=; b=m0QCr7ccrNCGuhX8UnMNpCo7rzVFhh80WY+7txmFPsUq1j3FY5Xw0V JsJ8CWJVANCnsEwa0rLac4DhIX03Apo3WYY1u9CoLu4aqTyIVLTxNTCpNdi9pHj3 2xWGKOol4eIXwz2zQhv5ttzjpwdF81pDTCFaH209phAr2UK3rpGZGR0q47Fap8d+ ooJcJXJ3ITe3Pq3T6B/VzUmRwZCdestUZAQ7CArK1i/seqvk75TzNhDPqAl7S00V z66nCFC4BbHg4t4HokoIF8Rdqkp1Ow0DxYwpqnBN0ul9zSFfLzangEvP3ONp6dSG BLohRI2cNZTZXaj39Kdpq4bOs5fsrWug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=t94kb92TUrnNwgW8z 3wcter+WouO8euAqSoDzgtU+Rs=; b=lQzCkhulF0YfnhLJrnaaE6fOD2GKg5rne AurnceMXcKXweApJZtxoSuH94wplzzuTnT9RHf6x5CLyA8ZXTocAhL4gJ/YbVh4f LXR4S9XcR6HMXsMykloq6t53Ma6nlo7NSdlXWRYh7Cmc5C1CMXxG5+5DX1wLBP9z fUQwDLgpxCQLaX5v1nI6pnEjQOvfSr3Px3xpJqyWwLkygieXsQkxqTSx1FD1mTbG NMeFoHp6J2vjAhjqAYSoLee7MnBxxzQpt/Aa9+fe0X0QrYIhlTJJb6ggu/OCUbZ+ vf4QC37zQlJw1ugOFGdPhPm52T5TssLX5c8saaqO/DOZhCHs8eUvQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehuddgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepgeefkeduuefgheeugeffueevffdvjedtjeektdfgtdeftdeggeevtdev ffejledunecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghdptghirhhruhhsqd gtihdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 25 Mar 2022 17:27:08 -0400 (EDT) Date: Fri, 25 Mar 2022 14:27:07 -0700 From: Andres Freund To: Robert Haas Cc: PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220325212707.fkevorahowgur5ux@alap3.anarazel.de> References: <20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-25 13:52:11 -0400, Robert Haas wrote: > On Fri, Mar 25, 2022 at 12:36 PM Andres Freund wrote: > > Create a CF entry for it, or enable CI on a github repo? > > I created a CF entry for it. Then I had to try to Google around to > find the URL from the cfbot, because it's not even linked from > commitfest.postgresql.org for some reason. #blamemagnus Yea, we really need to improve on that. I think Thomas has some hope of improving things after the release... > I don't think that the Windows CI is running the TAP tests for > contrib. At least, I can't find any indication of it in the output. So > it doesn't really help to assess how portable this test is, unless I'm > missing something. Yea. It's really unfortunate how vcregress.pl makes it hard to run all tests. And we're kind of stuck finding a way forward. It's easy enough to work around for individual tests by just adding them to the test file (like Thomas did nearby), but clearly that doesn't scale. Andrew wasn't happy with additional vcregress commands. The fact that vcregress doesn't run tests in parallel makes things take forever. And so it goes on. > I looked through the Linux output. It looks to me like that does run > the TAP tests for contrib. Unfortunately, the output is not in order > and is also not labelled, so it's hard to tell what output goes with > what contrib module. I named my test 001_basic.pl, but there are 12 of > those already. I see that 13 copies of 001_basic.pl seem to have > passed CI on Linux, so I guess the test ran and passed there. It seems > like it would be an awfully good idea to mention the subdirectory name > before each dump of output. Yea, the current output is *awful*. FWIW, the way it's hard to run tests the same way across platforms, the crappy output etc was one of the motivations behind the meson effort. If you just compare the output from both *nix and windows runs today with the meson output, it's imo night and day: https://cirrus-ci.com/task/5869668815601664?logs=check_world#L67 That's a recent run where I'd not properly mirrored 7c51b7f7cc0, leading to a failure on windows. Though it'd be more intersting to see a run with a failure. If one wants one can also see the test output of individual tests (it's always logged to a file). But I typically find that not useful for a 'general' test run, too much output. In that case there's a nice list of failed tests at the end: Summary of Failures: 144/219 postgresql:tap+vacuumlo / vacuumlo/t/001_basic.pl ERROR 0.48s (exit status 255 or signal 127 SIGinvalid) Ok: 218 Expected Fail: 0 Fail: 1 Unexpected Pass: 0 Skipped: 0 Timeout: 0 Greetings, Andres Freund